Frontend 3: Replace withValidation HOC with useValidation hook#9396
Open
camd wants to merge 1 commit intocamd/react-router-7from
Open
Frontend 3: Replace withValidation HOC with useValidation hook#9396camd wants to merge 1 commit intocamd/react-router-7from
camd wants to merge 1 commit intocamd/react-router-7from
Conversation
Removes the last remaining Higher-Order Component in the frontend by converting `withValidation` into a `useValidation` hook plus a shared `<ValidationGate>` component. Updates the three consumers (AlertsView, TestsView, InfraCompareView) to call the hook and wrap their subtree in the gate, and converts `ErrorMessages` from a class component to a functional component along the way. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
camd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last remaining Higher-Order Component in the frontend by converting
withValidationinto auseValidationhook plus a shared<ValidationGate>component. Updates the three consumers (AlertsView, TestsView, InfraCompareView) to call the hook and wrap their subtree in the gate, and convertsErrorMessagesfrom a class component to a functional component along the way.