Promote callback threads only while streams are active.#194
Open
Promote callback threads only while streams are active.#194
Conversation
Previously the client and server callback threads were promoted to real-time priority for their entire lifetime. Promote on the 0->1 active-stream transition and demote on 1->0 so idle contexts don't hold RT priority. Adds ipccore::EventLoopHandle::run_task to dispatch closures onto the event loop thread, since promote/demote must run on the target thread itself. Linux client demote is performed locally (SCHED_OTHER needs no privilege); the promote path still routes through the server via RPC.
kinetiknz
force-pushed
the
thread-demote
branch
from
fc7bf7d to
71c9d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the client and server callback threads were promoted to real-time priority for their entire lifetime. Promote on the 0->1 active-stream transition and demote on 1->0 so idle contexts don't hold RT priority.
Adds ipccore::EventLoopHandle::run_task to dispatch closures onto the event loop thread, since promote/demote must run on the target thread itself. Linux client demote is performed locally (SCHED_OTHER needs no privilege); the promote path still routes through the server via RPC.
Intended to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1784402 partially, along with mozilla/cubeb#843