Bug 2009927 - Add support for RPM files to signingscript#1353
Merged
Eijebong merged 5 commits intomozilla-releng:masterfrom Feb 24, 2026
Merged
Bug 2009927 - Add support for RPM files to signingscript#1353Eijebong merged 5 commits intomozilla-releng:masterfrom
Eijebong merged 5 commits intomozilla-releng:masterfrom
Conversation
Contributor
Author
hneiva
approved these changes
Feb 13, 2026
Contributor
hneiva
left a comment
hneiva
left a comment
There was a problem hiding this comment.
few nits, nothing blocking.
LGTM
jcristau
approved these changes
Feb 13, 2026
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
Should we be exposing the public key for this alongside the signed packages?
jcristau
approved these changes
Feb 24, 2026
Refactor write_signing_req_to_disk to support both single-file and multi-file signing requests. This was mostly lifted off of the old debsign implementation (934d772) but I fixed it to not have an intermediate allocation with the entire file content (since that's precisely what the code tries to avoid...). Also extends make_signing_req and sign_with_autograph to accept a "files" autograph method, passing a list of file objects instead of a single input.
RPM signing uses autograph's `/sign/files` route but despite it supporting multiple files at once we currently only support signing one file at a time because signingscript doesn't have explicit support for multi file signing. I didn't want to add to the problem (mozilla-releng#980) so I decided to just go with it for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes use of autograph's
/sign/filesroute (mozilla-services/autograph#1187) to sign RPM packages.