fix(update-doc): move createDocBlocks to dev schema, fix codegen#296
Open
LinoyMargan wants to merge 2 commits intomasterfrom
Open
fix(update-doc): move createDocBlocks to dev schema, fix codegen#296LinoyMargan wants to merge 2 commits intomasterfrom
LinoyMargan wants to merge 2 commits intomasterfrom
Conversation
createDocBlocks and its associated types (CreateBlockInput, TextBlock, BlockAlignment, etc.) only exist in the dev schema but were defined in .graphql.ts files validated against the production schema, causing codegen to fail with 10 errors. - Move createDocBlocks mutation to update-doc-tool.graphql.dev.ts - Import CreateDocBlocksMutation/Variables from graphql.dev/graphql - Import all dev-only types in helpers from graphql.dev/graphql - Add versionOverride: 'dev' to the createDocBlocks API request - Regenerate both graphql/ and graphql.dev/ type files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Run prettier on update-doc-tool files after codegen fix. Monday: https://monday.monday.com/boards/18404309029/pulses/11637822468 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createDocBlocksmutation and its associated types (CreateBlockInput,TextBlock,BlockAlignment, etc.) were living in production-schema files but only exist in the dev schema, causing codegen to fail with 10 validation errorscreateDocBlocksto a newupdate-doc-tool.graphql.dev.tsfileupdate-doc-tool.tsandupdate-doc-tool.helpers.tsto point tographql.dev/generated typesversionOverride: 'dev'to thecreateDocBlocksAPI request (required for dev-schema mutations)graphql/andgraphql.dev/type files — codegen now passes cleanlyMonday Item
https://monday.monday.com/boards/18404309029/pulses/11637822468
Test Plan
npm run codegen— both schemas generate with all[SUCCESS], no[FAILED]linesnpm run build— builds cleanlynpm test— all 759 tests pass across 30 suites🤖 Generated with Claude Code