mcp: add max body size limit for SSE + streamable HTTP#783
Open
TheodorNEngoy wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
mcp: add max body size limit for SSE + streamable HTTP#783TheodorNEngoy wants to merge 1 commit intomodelcontextprotocol:mainfrom
TheodorNEngoy wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Contributor
Author
|
Local sanity check: |
Contributor
|
Adding a default for this limit is a backwards incompatible behavior change, which we generally try to avoid. Isn't this already easy enough to achieve by wrapping the MCP HTTP Handler with https://godoc.corp.google.com/pkg/net/http#MaxBytesHandler? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a basic DoS guard for the built-in HTTP transports by limiting POST request body size.
MaxBodyBytestoSSEOptionsandStreamableHTTPOptions(default:DefaultMaxBodyBytes= 1_000_000; negative disables).MaxBodyBytestoSSEServerTransportandStreamableServerTransportfor custom handler usage.413 Request Entity Too Largewhen the limit is exceeded.Rationale: avoid unbounded
io.ReadAll(req.Body)buffering for network-exposed servers.