Refactor dock rendering logic and fix typo#1
Open
frisk-V3 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Dockコンポーネントにおけるタイポの修正、およびキー入力イベント処理時の描画ロジックの重複を共通化(リファクタリング)しました。
変更点
render_dock_component内のログ出力で[Dokc]となっていた箇所を[Dock]に修正。redraw)として切り出し、コードの可読性と保守性を向上。sel)が境界値に達しており、値が変わらない場合は再描画が走らないように条件式を整理。動作しなかったらすみません