Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 25 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request refactors the UI test target naming convention and related build configuration. The UI test target name changed from 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
scripts/patch-runner.sh (1)
10-10: Make the runner bundle name an input instead of hardcoding it here.
TEST_TARGETis now centralized inMakefile, but this line leaves one more copy of the runner name behind. Passing the runner app name/path into the script would keep the Makefile as the single source of truth and avoid another drift on the next rename.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/patch-runner.sh` at line 10, Change RUNNER_APP to be derived from an input (positional argument or environment variable) instead of the hardcoded name: read a runner-app argument (or $RUNNER_APP_INPUT) and set RUNNER_APP to that value if provided, otherwise fall back to the existing construction using RUNNER_DIR; update callers (Makefile) to pass TEST_TARGET (or the runner path) into the script so the Makefile remains the single source of truth. Ensure the script still uses the RUNNER_DIR fallback when no input is provided and keep the variable name RUNNER_APP unchanged for downstream usage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@devicekit-ios.xcodeproj/project.pbxproj`:
- Line 940: The project renamed the broadcast extension bundle ID to
com.mobilenext.devicekit.BroadcastUploadExtension but the extension lookup in
DeviceKit/View/BroadcastStarterView.swift still uses the old hardcoded string
"com.mobilenext.devicekit-ios.BroadcastUploadExtension"; update that hardcoded
identifier in BroadcastStarterView.swift to the new bundle ID everywhere it
appears (both occurrences flagged) so the app can find the renamed
BroadcastUploadExtension; verify any other code that references the old string
is similarly updated.
---
Nitpick comments:
In `@scripts/patch-runner.sh`:
- Line 10: Change RUNNER_APP to be derived from an input (positional argument or
environment variable) instead of the hardcoded name: read a runner-app argument
(or $RUNNER_APP_INPUT) and set RUNNER_APP to that value if provided, otherwise
fall back to the existing construction using RUNNER_DIR; update callers
(Makefile) to pass TEST_TARGET (or the runner path) into the script so the
Makefile remains the single source of truth. Ensure the script still uses the
RUNNER_DIR fallback when no input is provided and keep the variable name
RUNNER_APP unchanged for downstream usage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ccd49cd2-6282-440c-a323-a662c8065e1f
📒 Files selected for processing (4)
Makefiledevicekit-ios.xcodeproj/project.pbxprojdevicekit-ios.xcodeproj/xcshareddata/xcschemes/devicekit-ios.xcschemescripts/patch-runner.sh
| ); | ||
| MARKETING_VERSION = 1.0; | ||
| PRODUCT_BUNDLE_IDENTIFIER = "com.mobilenext.devicekit-ios"; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.mobilenext.devicekit; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Bundle identifiers defined in the Xcode project:"
rg -n 'PRODUCT_BUNDLE_IDENTIFIER = ' devicekit-ios.xcodeproj/project.pbxproj
echo
echo "Places where both the host app and runner app are installed or packaged together:"
rg -n '\$\(SCHEME\)\.app|\$\(TEST_TARGET\)-Runner\.app' MakefileRepository: mobile-next/devicekit-ios
Length of output: 1538
🏁 Script executed:
fd -t f 'BroadcastStarterView.swift' --exec cat -n {} \;Repository: mobile-next/devicekit-ios
Length of output: 1635
Keep the UI test runner bundle identifier distinct from the app, and update the hardcoded broadcast extension identifier.
The app target and the UI test target both resolve to com.mobilenext.devicekit (lines 800/858). Since both are installed together via xcrun simctl install (Makefile:110), they will contend for the same bundle identifier. The UI test target needs its own unique identifier, e.g., with a .uitests suffix.
Additionally, BroadcastStarterView.swift:6 hardcodes com.mobilenext.devicekit-ios.BroadcastUploadExtension, but the project now defines the broadcast extension as com.mobilenext.devicekit.BroadcastUploadExtension (lines 940, 991). This mismatch will cause the broadcast picker to fail at runtime.
1 participant
No description provided.