[Fix] Correct condition for image dilation in orientation estimation#1971
Merged
felixdittrich92 merged 1 commit intomindee:mainfrom Jun 25, 2025
Merged
Conversation
Razlaw
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
- Coverage 96.91% 96.87% -0.05%
==========================================
Files 172 172
Lines 8633 8633
==========================================
- Hits 8367 8363 -4
- Misses 266 270 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felixdittrich92
added
type: bug
Collaborator
|
@Razlaw I think at line 103 same case :) |
Razlaw
force-pushed
the
fix/dilate_only_if_page_orientation_is_none
branch
from
ae08a1e to
da16ec3
Compare
Contributor
Author
Nice catch 👍 I added that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1970