fix(#206): skip response.headers.set() in nextjs-no-side-effect rule#233
Open
william-garden wants to merge 1 commit into
Open
fix(#206): skip response.headers.set() in nextjs-no-side-effect rule#233william-garden wants to merge 1 commit into
william-garden wants to merge 1 commit into
Conversation
…ect rule The nextjs-no-side-effect-in-get-handler rule was incorrectly flagging response.headers.set() calls as security-risky side effects. These calls only shape the outbound response (Cache-Control, X-Deprecated, CORS headers) and are idiomatic Next.js - they don't mutate server state. This fix adds isResponseHeadersCall() to detect response.headers.set(), response.headers.append(), and response.headers.delete() calls and skip them during side effect detection.
|
🔴 React Review — 0/100 (unchanged) · No new issues Reviewed by react-review for commit a5bacbb. Configure here. |
|
@william-garden is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
NisargIO
added a commit
that referenced
this pull request
May 16, 2026
… in GET handlers (#206) Rewrites `nextjs-no-side-effect-in-get-handler` precision so it no longer floods Next.js codebases with false positives from `response.headers.set()` and request-scoped `new Map/Set/Headers/URLSearchParams/FormData(...)` mutations, while still catching real CSRF-relevant writes: drizzle/prisma ORM mutations, module-level mutable state, mutating fetch, and all three forms of `cookies().set/delete()` including aliased `const cs = await cookies(); cs.set(...)`. Also folds in the safe handler-resolution improvements from PR #251 (cron route skip and depth-bounded `const GET = withAuth(handler)` resolution). Supersedes #209, #211, #233, #238. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
NisargIO
added a commit
that referenced
this pull request
May 16, 2026
… in GET handlers (#206) Rewrites `nextjs-no-side-effect-in-get-handler` precision so it no longer floods Next.js codebases with false positives from `response.headers.set()` and request-scoped `new Map/Set/Headers/URLSearchParams/FormData(...)` mutations, while still catching real CSRF-relevant writes: drizzle/prisma ORM mutations, module-level mutable state, mutating fetch, and all three forms of `cookies().set/delete()` including aliased `const cs = await cookies(); cs.set(...)`. Also folds in the safe handler-resolution improvements from PR #251 (cron route skip and depth-bounded `const GET = withAuth(handler)` resolution). Supersedes #209, #211, #233, #238. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Working on a related fix in #260 that takes a slightly broader angle — covers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #206: False positive - nextjs-no-side-effect-in-get-handler flags Response.headers.set()
Problem
The
nextjs-no-side-effect-in-get-handlerrule was incorrectly flaggingresponse.headers.set()calls inside GET route handlers as security-risk side effects. These calls only shape the outbound response (Cache-Control, X-Deprecated, CORS headers) and are idiomatic Next.js — they do not mutate server state.Solution
Added
isResponseHeadersCall()function to detectresponse.headers.set(),response.headers.append(), andresponse.headers.delete()calls and skip them during side effect detection.Changes
packages/react-doctor/src/plugin/utils/is-response-headers-call.ts(new)packages/react-doctor/src/plugin/utils/find-side-effect.ts- skip response.headers callspackages/react-doctor/src/plugin/utils/index.ts- export new functionNote
Low Risk
Low risk predicate change to a lint rule to reduce false positives; main risk is potentially missing a real side effect if code matches the new
response.headers.*call shape unexpectedly.Overview
Updates side-effect detection used by
nextjs-no-side-effect-in-get-handlerto ignoreresponse.headers.set(),.append(), and.delete()calls so response header shaping is no longer reported as a server-state mutation.Adds a new
isResponseHeadersCallAST predicate and exports it via the utils index, then short-circuitsfindSideEffectwhen this call pattern is encountered.Reviewed by Cursor Bugbot for commit a5bacbb. Bugbot is set up for automated code reviews on this repo. Configure here.