Add npm override to eliminate quarantined es5-ext#17
Conversation
The pnpm.overrides field is ignored by npm, which Konflux uses for hermetic builds. This adds a top-level "overrides" field and replaces the direct epubjs dependency so npm's package-lock.json also resolves to @likecoin/epub-ts, fully eliminating the quarantined es5-ext package. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, mpryc, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Summary
pnpm.overridesto replaceepubjswith@likecoin/epub-ts, but Konflux hermetic builds use npm (not pnpm), sopackage-lock.jsonstill resolvedes5-ext"overrides"field (npm-compatible) and replaces the directepubjsdependency with the fork, fully removinges5-extfrompackage-lock.jsones5-exthas 0 references in the regenerated lockfile, typecheck and tests passTest plan
es5-ext.epubfile, verify rendering, font size controls, dark mode)🤖 Generated with Claude Code