Fix es5 ext#14
Closed
weshayutin wants to merge 31 commits into
Closed
Conversation
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
build: first pass at a konflux dockerfile
Hermeto/Cachi2 requires package-lock.json (or npm-shrinkwrap.json) for npm dependency pre-fetching during hermetic Konflux builds. pnpm-lock.yaml is not supported by Hermeto's npm handler. Generated via: npm install --package-lock-only Lockfile version: 3 Signed-off-by: Michal Pryc <mpryc@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
UPSTREAM: <carry>: Add package-lock.json for Konflux hermetic builds
New config option: --branding.disableUserProfile This option allows to disable User Profile together with User settings. Signed-off-by: Michal Pryc <mpryc@redhat.com>
New config option: --branding.defaultLoginUser "username" This option allows to provide default Username, which will result in hiding username field from the welcome page. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Removes Help options "Delete" and "Rename" if the following permissions are revoked from a particular user: --perm.delete=false --perm.rename=false Signed-off-by: Michal Pryc <mpryc@redhat.com>
Add multi-stage Containerfile for UBI-based builds. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Adds OWNERS file. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Fix downstream changes to match upstream refactored functions. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Hermeto/Cachi2 requires package-lock.json (or npm-shrinkwrap.json) for npm dependency pre-fetching during hermetic Konflux builds. pnpm-lock.yaml is not supported by Hermeto's npm handler. Generated via: npm install --package-lock-only Lockfile version: 3 Signed-off-by: Michal Pryc <mpryc@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
In hermetic Konflux/Cachi2 builds, network access is blocked, causing `npm install -g pnpm` to fail with ENOTFOUND when trying to reach registry.npmjs.org. Replace pnpm with npm clean-install, consistent with how mta-ui and mta-static-report handle npm dependencies in hermetic builds. package-lock.json is already present in the frontend/ directory. Changes: - Remove pnpm install, use npm clean-install --ignore-scripts --no-audit --verbose - Replace pnpm run build with npm run typecheck && npx vite build (the package.json build script references pnpm internally) - Remove go mod download, Cachi2 pre-fetches Go modules and makes them available via cachi2.env GOMODCACHE - Consolidate LABEL instructions into single multi-line block - Fix extra space in io.k8s.description label Signed-off-by: Michal Pryc <mpryc@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous package-lock.json was out of sync with package.json after rebase, causing version mismatches (e.g. vite@7.3.2 vs ^8.0.0) and preventing Cachi2 from properly pre-fetching npm dependencies. Regenerated using registry.access.redhat.com/ubi9/nodejs-24:latest (Node.js v24.13.0, npm 11.6.2) to match the builder image. Signed-off-by: Michal Pryc <mpryc@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use npm instead of pnpm for hermetic Konflux builds
New config option: --branding.disableUserProfile This option allows to disable User Profile together with User settings. Signed-off-by: Michal Pryc <mpryc@redhat.com>
New config option: --branding.defaultLoginUser "username" This option allows to provide default Username, which will result in hiding username field from the welcome page. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Removes Help options "Delete" and "Rename" if the following permissions are revoked from a particular user: --perm.delete=false --perm.rename=false Signed-off-by: Michal Pryc <mpryc@redhat.com>
Add multi-stage Containerfile for UBI-based builds. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Adds OWNERS file. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Fix downstream changes to match upstream refactored functions. Signed-off-by: Michal Pryc <mpryc@redhat.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
Hermeto/Cachi2 requires package-lock.json (or npm-shrinkwrap.json) for npm dependency pre-fetching during hermetic Konflux builds. pnpm-lock.yaml is not supported by Hermeto's npm handler. Generated via: npm install --package-lock-only Lockfile version: 3 Signed-off-by: Michal Pryc <mpryc@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
In hermetic Konflux/Cachi2 builds, network access is blocked, causing `npm install -g pnpm` to fail with ENOTFOUND when trying to reach registry.npmjs.org. Replace pnpm with npm clean-install, consistent with how mta-ui and mta-static-report handle npm dependencies in hermetic builds. package-lock.json is already present in the frontend/ directory. Changes: - Remove pnpm install, use npm clean-install --ignore-scripts --no-audit --verbose - Replace pnpm run build with npm run typecheck && npx vite build (the package.json build script references pnpm internally) - Remove go mod download, Cachi2 pre-fetches Go modules and makes them available via cachi2.env GOMODCACHE - Consolidate LABEL instructions into single multi-line block - Fix extra space in io.k8s.description label Signed-off-by: Michal Pryc <mpryc@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous package-lock.json was out of sync with package.json after rebase, causing version mismatches (e.g. vite@7.3.2 vs ^8.0.0) and preventing Cachi2 from properly pre-fetching npm dependencies. Regenerated using registry.access.redhat.com/ubi9/nodejs-24:latest (Node.js v24.13.0, npm 11.6.2) to match the builder image. Signed-off-by: Michal Pryc <mpryc@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Disable Validate Title check (semantic commit PR titles are not used downstream). Fix Go version to 1.25 and add oadp-* branches to CI triggers.
requires removal of es5-ext in depth explanation in doc/eliminate-es5-ext.md Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@weshayutin: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (21)
📝 WalkthroughWalkthroughThis PR implements user profile control branding features while introducing containerization infrastructure, updating CI toolchain versions, establishing code ownership, and addressing a frontend dependency security issue. The changes span backend configuration, HTTP template injection, and frontend UI gating to conditionally disable user profile access and support pre-filled login credentials. ChangesUser Profile Control Feature
Infrastructure, Build & Dependency Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eliminate es5-ext via pnpm Override
Background
es5-ext@0.10.64is a transitive dependency pulled in viavue-reader->epubjs@0.3.93->event-emitter->es5-extChosen Approach: pnpm Override with @likecoin/epub-ts
@likecoin/epub-ts (v0.6.3, Apr 2026) is a TypeScript rewrite of epubjs v0.3.93 that:
jszip) -- no es5-ext, no event-emitter, no d, no es6-iteratorBook,Rendition,Themes,Contents, etc.requestCredentials,getRendition,themes.override-- everything used infrontend/src/views/files/Preview.vueSummary by CodeRabbit
Release Notes
New Features
Chores