Query Insights: Update model & refine prompt components

[xingfan-git]

Updated the prompt structure to mitigate prompt injection attacks. The changes include:

• Separated prompt components into a crafted prompt (instructions), user query (user input), and context data (system-retrieved data).
• Set the crafted prompt as an assistant message, while the user query and context data are provided as a user message.
• Wrapped the user query and context data in explicit delimiters and clearly instructed the model to treat them strictly as data.
• Added security-focused prompt components, including PRIORITY DECLARATION, SECURITY INSTRUCTIONS, and CRITICAL_JSON_REMINDER.

Set the default model as gpt-4o to provide faster response

[Copilot]

Pull request overview

This pull request refactors the LLM prompt architecture to improve security against prompt injection attacks and updates the preferred model from 'gpt-5' to 'gpt-4o'.

Changes:

• Updated the preferred LLM model from 'gpt-5' (non-existent) to 'gpt-4o', with 'gpt-4o-mini' as the fallback
• Introduced a new FilledPromptResult interface to separate prompt components into craftedPrompt (instructions), userQuery (user input), and contextData (system-retrieved data)
• Refactored message structure to use Assistant role for instructions and User role for data, implementing a prompt injection defense pattern
• Added security-focused prompt components including PRIORITY DECLARATION, SECURITY INSTRUCTIONS, and CRITICAL_JSON_REMINDER
• Updated all prompt templates with new structure including data placeholder documentation sections

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
src/commands/llmEnhancedCommands/promptTemplates.ts	Major refactoring: changed model configuration, added new utility functions for security-focused prompts, created FilledPromptResult interface, and restructured all prompt templates with security instructions and data placeholder documentation
src/commands/llmEnhancedCommands/queryGenerationCommands.ts	Updated fillPromptTemplate to return FilledPromptResult components and refactored message construction to use Assistant/User role pattern for security
src/commands/llmEnhancedCommands/indexAdvisorCommands.ts	Updated fillPromptTemplate to return FilledPromptResult components, refactored message construction to match new pattern, and updated telemetry calculation

[tnaum-ms]

@xingfan-git please resolve copilot's concerns, and add a description in the PR that explains why the applied solution is an effective approach against 'prompt injections'.

[xingfan-git]

@copilot summarize the PR and generate description

[Copilot]

@xingfan-git I've opened a new pull request, #475, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.