Rationalize Trace, Debug, and Info log levels#439
Open
Rationalize Trace, Debug, and Info log levels#439
Conversation
Establish a clear logging hierarchy: - Info: high-level flow (bot started, activity received/finished, route dispatched) - Debug: HTTP responses with status codes, middleware execution, token acquisition - Trace: full JSON payloads, token claims, selector evaluation, OIDC resolution Key changes: - Demote token acquisition, API endpoint, and HTTP-detail logs from Info to Debug - Promote route dispatch logs from Debug to Info for flow visibility - Centralize HTTP request/response logging in BotHttpClient (remove duplicates) - Add LogDebugGuarded extensions matching existing LogTraceGuarded pattern - Add incoming JWT token claims logging at Trace in JwtExtensions - Add middleware pipeline logging (registration, execution, completion) - Add handler registration logging in Router.Register - Add streaming lifecycle logging in TeamsStreamingWriter - Add error logging in CompatAdapter before OnTurnError delegation - Add route selector evaluation logging at Trace level - Add OIDC authority resolution logging at Trace level Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR aims to standardize log level usage (Info/Debug/Trace) across the SDK and samples, reduce duplicate HTTP logging, and add instrumentation/diagnostics to previously silent areas. It also introduces several API surface updates (cancellation token support, invoke activity Value accessibility, targeted messaging/reactions additions), updates sample configurations, and adjusts CI/pipeline definitions.
Changes:
- Harmonize logging configuration across samples and add/adjust log-related infrastructure (incl. guarded logging patterns and centralized HTTP logging per description).
- Add cancellation-token-aware overloads across multiple client and streaming APIs; add new invoke/sign-in failure activity types and routing support.
- Update samples, tests, and CI/devcontainer/pipelines to align with the updated APIs and runtime/tooling versions.
Reviewed changes
Copilot reviewed 294 out of 482 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| core/samples/TeamsBot/GlobalSuppressions.cs | Adds code analysis suppression for sample project |
| core/samples/TabApp/appsettings.json | Adds default logging/hosts config for TabApp sample |
| core/samples/TabApp/Web/vite.config.ts | Adds Vite config for TabApp web build output |
| core/samples/TabApp/Web/tsconfig.json | Adds TypeScript configuration for TabApp web |
| core/samples/TabApp/Web/src/main.tsx | Adds React entry point for TabApp web |
| core/samples/TabApp/Web/package.json | Adds npm deps/scripts for TabApp web build |
| core/samples/TabApp/Web/index.html | Adds HTML entry for TabApp web |
| core/samples/TabApp/TabApp.csproj | Adds TabApp sample project targeting net10.0 |
| core/samples/TabApp/Program.cs | Adds Tab hosting + sample function endpoint |
| core/samples/TabApp/Body.cs | Adds request/response types for TabApp endpoint |
| core/samples/StreamingBot/appsettings.json | Normalizes logging levels/config keys |
| core/samples/StreamingBot/StreamingBot.csproj | Updates sample target framework and deps |
| core/samples/Proactive/appsettings.json | Updates logging category configuration |
| core/samples/Proactive/Worker.cs | Adds proactive worker sample with logging |
| core/samples/Proactive/Program.cs | Adds worker host wiring for proactive sample |
| core/samples/Proactive/Proactive.csproj | Adds worker sample project targeting net10.0 |
| core/samples/PABot/appsettings.json | Adds baseline appsettings file |
| core/samples/PABot/Properties/launchSettings.TEMPLATE.json | Adds launch settings template w/ env vars |
| core/samples/PABot/Program.cs | Adds sample program wiring for compat bot |
| core/samples/PABot/PABot.csproj | Adds/updates PABot sample project refs |
| core/samples/PABot/Bots/EchoBot.cs | Adds EchoBot sample implementation |
| core/samples/PABot/AdapterWithErrorHandler.cs | Adds compat adapter w/ error handling |
| core/samples/MessageExtensionBot/appsettings.json | Normalizes logging levels/config |
| core/samples/MessageExtensionBot/README.md | Adds testing guide for message extension sample |
| core/samples/MessageExtensionBot/MessageExtensionBot.csproj | Adds sample project targeting net10.0 |
| core/samples/MeetingsBot/appsettings.json | Normalizes logging levels/config |
| core/samples/MeetingsBot/README.md | Adds meetings sample documentation |
| core/samples/MeetingsBot/Program.cs | Adds meetings handlers sample code |
| core/samples/MeetingsBot/MeetingsBot.csproj | Adds sample project targeting net10.0 |
| core/samples/Directory.Build.props | Enforces NuGet audit + warnings-as-errors in samples |
| core/samples/CustomHosting/appsettings.json | Adds sample logging/hosts config |
| core/samples/CustomHosting/Program.cs | Adds custom hosting sample program |
| core/samples/CustomHosting/MyTeamsBotApp.cs | Adds custom TeamsBotApplication subclass sample |
| core/samples/CustomHosting/CustomHosting.csproj | Adds sample project targeting net10.0 |
| core/samples/CoreBot/appsettings.json | Sets Microsoft.Teams logging to Trace for sample |
| core/samples/CoreBot/Program.cs | Adds core bot sample program |
| core/samples/CoreBot/CoreBot.csproj | Adds sample project targeting net10.0 |
| core/samples/CompatProactive/appsettings.json | Normalizes logging levels/config |
| core/samples/CompatProactive/Program.cs | Adds compat proactive worker host |
| core/samples/CompatProactive/ProactiveWorker.cs | Adds compat proactive send worker |
| core/samples/CompatProactive/CompatProactive.csproj | Adds compat proactive sample project |
| core/samples/CompatBot/appsettings.json | Normalizes logging levels/config |
| core/samples/CompatBot/Program.cs | Adds compat bot sample wiring |
| core/samples/CompatBot/MyCompatMiddleware.cs | Adds sample middleware with console output |
| core/samples/CompatBot/CompatBot.csproj | Adds compat bot sample project |
| core/samples/CompatBot/Cards.cs | Adds sample adaptive card payload helpers |
| core/samples/AllInvokesBot/manifest.json | Adds sample Teams manifest |
| core/samples/AllInvokesBot/appsettings.json | Normalizes logging levels/config |
| core/samples/AllInvokesBot/README.md | Adds testing guide for invoke handlers |
| core/samples/AllInvokesBot/AllInvokesBot.csproj | Adds sample project targeting net10.0 |
| core/samples/AllFeatures/appsettings.json | Adds sample logging/hosts config |
| core/samples/AllFeatures/Program.cs | Adds multi-feature sample program |
| core/samples/AllFeatures/AllFeatures.http | Adds HTTP scratch file for sample |
| core/samples/AllFeatures/AllFeatures.csproj | Adds sample project targeting net10.0 |
| core/samples/AFBot/appsettings.json | Updates logging config for AF bot sample |
| core/samples/AFBot/Program.cs | Adds AI/agent-driven sample bot program |
| core/samples/AFBot/DropTypingMiddleware.cs | Adds middleware filtering typing activities |
| core/samples/AFBot/AFBot.csproj | Adds AI sample project and package refs |
| core/.gitignore | Ignores launch/appsettings dev + web build artifacts |
| core/.editorconfig | Adds C# conventions + sample/test rule overrides |
| Tests/Microsoft.Teams.Apps.Tests/Microsoft.Teams.Apps.Tests.csproj | Adjusts warnings and package references |
| Tests/Microsoft.Teams.Api.Tests/Microsoft.Teams.Api.Tests.csproj | Suppresses experimental warnings in tests |
| Tests/Microsoft.Teams.Api.Tests/Json/Activity/Message/MessageReactionActivity.json | Updates reaction JSON fixture |
| Tests/Microsoft.Teams.Api.Tests/Json/Activity/Invokes/SignInFailureActivity.json | Adds new sign-in failure JSON fixture |
| Tests/Microsoft.Teams.Api.Tests/Clients/ReactionClientTests.cs | Adds tests for reactions client HTTP calls |
| Tests/Microsoft.Teams.Api.Tests/Activities/Message/MessageReactionActivityTests.cs | Updates tests to remove obsolete reaction builder usage |
| Tests/Microsoft.Teams.Api.Tests/Activities/Invokes/Tasks/TasksTests.cs | Adds tests for base/derived Value accessibility |
| Tests/Microsoft.Teams.Api.Tests/Activities/Invokes/MessageExtensions/MessageExtensionsTests.cs | Adds tests for base/derived Value accessibility |
| Tests/Microsoft.Teams.Api.Tests/Activities/Invokes/AdaptiveCards/AdaptiveCardsTests.cs | Adds tests for base/derived Value accessibility |
| Samples/Samples.TargetedMessages/appsettings.json | Adjusts runtime config keys (hosts/settings) |
| Samples/Samples.TargetedMessages/appsettings.Development.json | Adds development logging config |
| Samples/Samples.TargetedMessages/Samples.TargetedMessages.csproj | Adds sample project targeting net10.0 |
| Samples/Samples.TargetedMessages/Properties/launchSettings.TEMPLATE.json | Updates env var template for Teams config |
| Samples/Samples.Tab/appsettings.json | Adjusts log level + Teams config keys |
| Samples/Samples.Tab/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.Tab/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Samples.Tab/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template |
| Samples/Samples.Reactions/appsettings.json | Adjusts logging config layout |
| Samples/Samples.Reactions/Samples.Reactions.csproj | Adds sample project + experimental suppression |
| Samples/Samples.Reactions/Properties/launchSettings.TEMPLATE.json | Standardizes launch template |
| Samples/Samples.Reactions/Program.cs | Adds sample demonstrating reaction APIs and handlers |
| Samples/Samples.MessageExtensions/appsettings.json | Adjusts logging + Teams config keys |
| Samples/Samples.MessageExtensions/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.MessageExtensions/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Samples.MessageExtensions/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template |
| Samples/Samples.MessageExtensions/Program.cs | Updates handlers to accept/use cancellation tokens |
| Samples/Samples.Meetings/appsettings.json | Adjusts logging + Teams config keys |
| Samples/Samples.Meetings/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template |
| Samples/Samples.Meetings/Program.cs | Updates handlers to accept/use cancellation tokens |
| Samples/Samples.McpClient/appsettings.json | Adjusts logging + Teams config keys |
| Samples/Samples.McpClient/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.McpClient/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Samples.McpClient/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template incl. OpenAI env vars |
| Samples/Samples.Mcp/appsettings.json | Adjusts log level + Teams config keys |
| Samples/Samples.Mcp/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.Mcp/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Samples.Mcp/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template incl. OpenAI env vars |
| Samples/Samples.Lights/appsettings.json | Adjusts log level + Teams config keys |
| Samples/Samples.Lights/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.Lights/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Samples.Lights/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template incl. OpenAI env vars |
| Samples/Samples.Lights/Program.cs | Updates handlers to accept/use cancellation tokens |
| Samples/Samples.Graph/appsettings.json | Adjusts log level + Teams config keys |
| Samples/Samples.Graph/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.Graph/README.md | Updates prerequisites and launchSettings guidance |
| Samples/Samples.Graph/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Samples.Graph/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template |
| Samples/Samples.Graph/Program.cs | Adds sign-in failure handler + cancellation tokens |
| Samples/Samples.Echo/appsettings.json | Adjusts log level + Teams config keys |
| Samples/Samples.Echo/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.Echo/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Samples.Echo/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template |
| Samples/Samples.Echo/Program.cs | Updates handlers to accept/use cancellation tokens |
| Samples/Samples.Dialogs/appsettings.json | Adjusts log level + Teams config keys |
| Samples/Samples.Dialogs/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Samples.Dialogs/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template |
| Samples/Samples.Dialogs/Program.cs | Updates handlers to accept/use cancellation tokens |
| Samples/Samples.Cards/appsettings.json | Adjusts log level + Teams config keys |
| Samples/Samples.Cards/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.Cards/Properties/launchSettings.TEMPLATE.json | Standardizes launch template |
| Samples/Samples.BotBuilder/appsettings.json | Adjusts log level + removes unused config keys |
| Samples/Samples.BotBuilder/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.BotBuilder/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template |
| Samples/Samples.BotBuilder/Program.cs | Updates handlers to accept/use cancellation tokens |
| Samples/Samples.AI/appsettings.json | Adds Teams config + logging section |
| Samples/Samples.AI/appsettings.Development.json | Removes redundant development config file |
| Samples/Samples.AI/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template w/ Azure OpenAI env vars |
| Samples/Samples.AI/Handlers/MemoryManagementHandler.cs | Adds cancellation token support in handler |
| Samples/Samples.AI/Handlers/FunctionCallingHandler.cs | Adds cancellation token support in handler |
| Samples/Samples.AI/Handlers/FeedbackHandler.cs | Adds cancellation token support in handler |
| Samples/Samples.AI/Handlers/CitationsHandler.cs | Adds cancellation token support in handler |
| Samples/Deprecated.Controllers/appsettings.json | Adds Teams config + logging section |
| Samples/Deprecated.Controllers/Properties/launchSettings.json | Removes checked-in local launch settings |
| Samples/Deprecated.Controllers/Properties/launchSettings.TEMPLATE.json | Adds standardized launch template |
| Samples/Deprecated.Controllers/Program.cs | Fixes using ordering in sample program |
| Samples/Deprecated.Controllers/MainController.cs | Fixes using ordering in controller |
| README.md | Adds guidance about preview packages |
| Libraries/Microsoft.Teams.Plugins/Microsoft.Teams.Plugins.AspNetCore/Extensions/ApplicationBuilder.cs | Removes unused auth import |
| Libraries/Microsoft.Teams.Plugins/Microsoft.Teams.Plugins.AspNetCore/AspNetCorePlugin.cs | Adds targeted messaging behavior for send/update |
| Libraries/Microsoft.Teams.Plugins/Microsoft.Teams.Plugins.AspNetCore/AspNetCorePlugin.Stream.cs | Adds cancellation token support to stream close |
| Libraries/Microsoft.Teams.Plugins/Microsoft.Teams.Plugins.AspNetCore.DevTools/Microsoft.Teams.Plugins.AspNetCore.DevTools.csproj | Updates System.IdentityModel.Tokens.Jwt version |
| Libraries/Microsoft.Teams.Apps/Plugins/Streamer.cs | Updates stream interface to accept cancellation token |
| Libraries/Microsoft.Teams.Apps/Contexts/Client/FunctionContext.cs | Adds cancellation token overloads to Send methods |
| Libraries/Microsoft.Teams.Apps/AppRouting.cs | Adds sign-in failure invoke default handler |
| Libraries/Microsoft.Teams.Apps/App.cs | Adds sign-in failure registration + token propagation |
| Libraries/Microsoft.Teams.Apps/Annotations/ContextAttribute.cs | Removes unused extensions import |
| Libraries/Microsoft.Teams.Apps/Activities/TypingActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Messages/MessageUpdateActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Messages/MessageReactionActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Messages/MessageDeleteActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Messages/MessageActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Tasks/SubmitActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Tasks/FetchActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Tabs/SubmitActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Tabs/FetchActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/SignIn/VerifyStateAcitivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/SignIn/TokenExchangeActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Search/TypeaheadSearchActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Search/SearchActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Search/AnswerSearchActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Messages/SubmitActionActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Messages/FeedbackActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/SubmitActionActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/SettingsActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/SelectItemActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/QuerySettingsUrlActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/QueryLinkActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/QueryActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/FetchTaskActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/CardButtonClickedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/MessageExtensions/AnonQueryLinkActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/InvokeActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/HandoffActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/FileConsentActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/ExecuteActionActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Configs/SubmitActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/Configs/FetchActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Invokes/AdaptiveCards/ActionActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Installs/UnInstallActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Installs/InstallUpdateActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Installs/InstallActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Events/ReadReceiptActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Events/MeetingStartActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Events/MeetingLeaveActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Events/MeetingJoinActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Events/MeetingEndActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Events/EventActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/TeamUnArchivedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/TeamRestoredActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/TeamRenamedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/TeamDeletedActivity.cs | Adds CancellationToken overload registrations |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/TeamArchivedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/MembersRemovedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/MembersAddedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ConversationUpdateActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ConversationEndActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ChannelUnsharedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ChannelSharedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ChannelRestoredActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ChannelRenamedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ChannelMemberRemovedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ChannelMemberAddedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ChannelDeletedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/Conversations/ChannelCreatedActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/CommandResultActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps/Activities/CommandActivity.cs | Adds CancellationToken overload registration |
| Libraries/Microsoft.Teams.Apps.Testing/Plugins/TestPlugin.Stream.cs | Updates test streamer close signature |
| Libraries/Microsoft.Teams.Api/SignIn/Failure.cs | Adds new sign-in failure model |
| Libraries/Microsoft.Teams.Api/Microsoft.Teams.Api.csproj | Updates System.IdentityModel.Tokens.Jwt version |
| Libraries/Microsoft.Teams.Api/Messages/Reaction.cs | Updates reactions model + marks experimental |
| Libraries/Microsoft.Teams.Api/Messages/Message.cs | Suppresses experimental warning around reactions |
| Libraries/Microsoft.Teams.Api/Clients/UserTokenClient.cs | Adds cancellation tokens to token client methods |
| Libraries/Microsoft.Teams.Api/Clients/TeamClient.cs | Adds cancellation tokens to team client methods |
| Libraries/Microsoft.Teams.Api/Clients/MemberClient.cs | Adds cancellation tokens to member client methods |
| Libraries/Microsoft.Teams.Api/Clients/MeetingClient.cs | Adds cancellation tokens to meeting client methods |
| Libraries/Microsoft.Teams.Api/Clients/ConversationClient.cs | Adds reactions sub-client + cancellation token overload |
| Libraries/Microsoft.Teams.Api/Clients/BotTokenClient.cs | Adds cancellation token support for token resolution |
| Libraries/Microsoft.Teams.Api/Clients/BotSignInClient.cs | Adds cancellation token support for sign-in URL calls |
| Libraries/Microsoft.Teams.Api/Clients/ApiClient.cs | Exposes underlying HTTP client + adds token-scoped clone ctor |
| Libraries/Microsoft.Teams.Api/App.cs | Makes App.Id nullable for payloads |
| Libraries/Microsoft.Teams.Api/Activities/Message/MessageReactionActivity.cs | Marks reaction helpers obsolete; wraps experimental warnings |
| Libraries/Microsoft.Teams.Api/Activities/Message/MessageActivity.cs | Adds targeted recipient overloads |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/Tasks/SubmitActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/Tasks/FetchActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/Tabs/SubmitActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/Tabs/FetchActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/SignInActivity.cs | Adds signin/failure polymorphic handling |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/SignIn/VerifyStateActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/SignIn/TokenExchangeActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/SignIn/FailureActivity.cs | Adds new signin/failure invoke activity type |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/SearchActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/Messages/SubmitActionActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/MessageExtensions/SubmitActionActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/MessageExtensions/SettingActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/MessageExtensions/QuerySettingUrlActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/MessageExtensions/QueryLinkActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/MessageExtensions/QueryActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/MessageExtensions/FetchTaskActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/MessageExtensions/AnonQueryLinkActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/HandoffActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Invokes/AdaptiveCards/ActionActivity.cs | Makes derived Value map to base Value |
| Libraries/Microsoft.Teams.Api/Activities/Activity.cs | Adds targeted messaging fields + recipient overloads |
| Libraries/Microsoft.Teams.Api/Account.cs | Adds isTargeted flag on account (experimental) |
| .github/workflows/core-test.yaml | Adds manual core test workflow |
| .github/workflows/core-ci.yaml | Adds core CI build/test workflow for next/core |
| .github/workflows/codeql.yml | Extends CodeQL to next/core branch |
| .devcontainer/devcontainer.json | Updates devcontainer features incl. .NET 10 + dind |
| .azdo/ci.yaml | Refactors main PR pipeline to publish test results/artifacts |
| .azdo/cd-core.yaml | Adds core path filters + condition refactor + renames artifact |
Files not reviewed (1)
- core/samples/TabApp/Web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| file_header_template = Copyright (c) Microsoft Corporation.\nLicensed under the MIT License. | ||
|
|
||
| [samples/**/*.cs] | ||
| dotnet_diagnostic.CA1848.severity = none # Suppress Logger perfomance in samples |
There was a problem hiding this comment.
Corrected spelling of 'perfomance' to 'performance'.
Suggested change
| dotnet_diagnostic.CA1848.severity = none # Suppress Logger perfomance in samples | |
| dotnet_diagnostic.CA1848.severity = none # Suppress Logger performance in samples |
Comment on lines
+1
to
+4
| # ============================================================================= | ||
| # This pipeline (teams.net-pr) builds, tests, and packs the SDK (excluding core/). | ||
| # PR trigger: main and release/* branches. No CI trigger. | ||
| # ============================================================================= |
There was a problem hiding this comment.
The PR title/description focuses on log level rationalization and HTTP logging centralization, but this change set also includes substantial CI/pipeline changes (and elsewhere: new invoke types, targeted messaging/reactions, cancellation-token API changes, and many sample additions). Consider updating the PR description to reflect these broader changes or splitting into focused PRs to keep review scope manageable.
Member
Author
|
@copilot apply changes based on the comments in this thread |
- Add missing `_logger` field in CompatAdapter (fixes CS0103 build error) - Add null-safety for sign-in failure Value in AppRouting - Fix 'perfomance' typo in core/.editorconfig - Remove duplicate file header in PABot/EchoBot.cs - Replace placeholder suppression justification in GlobalSuppressions.cs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BotHttpClient— remove duplicate URL logs fromConversationClient,TeamsApiClient, andUserTokenClientLogDebugGuardedextensions matching existingLogTraceGuardedpatternTest plan
dotnet build— 0 errors, 0 warnings across all source projectsdotnet test— 541 tests pass (Core 121×2, Apps 129×2, Compat 41)"Microsoft.Teams": "Information"— flow: started → activity received → route dispatched → finished"Microsoft.Teams": "Debug"— adds HTTP status codes, middleware steps, token acquisition"Microsoft.Teams": "Trace"— adds full JSON payloads, token claims, selector results🤖 Generated with Claude Code