Add CompatTeamsSSOTokenExchangeMiddleware#436
Open
Conversation
The BF SDK's TeamsSSOTokenExchangeMiddleware triggers code paths through TeamsActivityHandler.OnTeamsMembersAddedDispatchAsync that call TeamsInfo.GetMemberAsync, which casts IConversations to the concrete Conversations class. This fails with InvalidCastException because CompatConversations only implements IConversations: System.InvalidCastException: Unable to cast object of type 'Microsoft.Teams.Bot.Compat.CompatConversations' to type 'Microsoft.Bot.Connector.Conversations'. This adds CompatTeamsSSOTokenExchangeMiddleware as a drop-in replacement that works with CompatUserTokenClient. Calling code should use this middleware and CompatTeamsInfo instead of the BF SDK equivalents. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompatTeamsSSOTokenExchangeMiddlewareas a drop-in replacement for the BF SDK'sTeamsSSOTokenExchangeMiddlewarethat works with the Teams Bot Core SDK viaCompatUserTokenClientSystem.InvalidCastException: Unable to cast object of type 'CompatConversations' to type 'Microsoft.Bot.Connector.Conversations'thrown when BF SDK'sTeamsInfo.GetMemberAsyncis invoked throughTeamsActivityHandler.OnTeamsMembersAddedDispatchAsyncCompatTeamsSSOTokenExchangeMiddleware+CompatTeamsInfoinstead of the BF SDK equivalentsError details
The BF SDK's
TeamsInfo.GetMemberAsynccastsIConversationsto the concreteConversationsclass. SinceCompatConversationsonly implementsIConversations(not extending the concrete class), this cast fails. The compat middleware avoids triggering BF SDK code paths that perform this cast.Test plan
CompatTeamsSSOTokenExchangeMiddlewarein place ofTeamsSSOTokenExchangeMiddlewarein an SSO sample botCompatTeamsInfoinstead ofTeamsInfoin bot handlersInvalidCastException🤖 Generated with Claude Code