[heft-lint-plugin] Stabilize linter cache filename using tsconfig path hash#5437
Merged
dmichon-msft merged 4 commits intomainfrom Dec 2, 2025
Merged
[heft-lint-plugin] Stabilize linter cache filename using tsconfig path hash#5437dmichon-msft merged 4 commits intomainfrom
dmichon-msft merged 4 commits intomainfrom
Conversation
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Stabilize hash suffix in linter cache file
[heft-lint-plugin] Stabilize linter cache filename using tsconfig path hash
Nov 7, 2025
dmichon-msft
requested changes
Nov 7, 2025
Contributor
dmichon-msft
left a comment
There was a problem hiding this comment.
Get the config file path from the program's getCompilerOptions().configFilePath (may require null checking). This will greatly simplify the code change.
Contributor
|
@copilot address feedback |
…se64url encoding, and sort files Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Contributor
Author
Done in commit ba0baea. The implementation now uses program.getCompilerOptions().configFilePath as suggested, which greatly simplified the code. |
Contributor
|
@copilot Run |
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Contributor
Author
dmichon-msft
approved these changes
Nov 27, 2025
bmiddha
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The linter cache filename used a hash of all input filenames, causing cache churn when files were added/removed. This stabilizes the cache filename by hashing the tsconfig path instead, while moving the files hash into the cache data for validation.
Fixes #5436
Details
Cache filename generation (
LinterBase.ts):program.getCompilerOptions().configFilePathILinterCacheData.filesHashfield for cache validationbase64urlencoding for hashes (filesHash without truncation, hashSuffix truncated to 8 chars for filename)cacheVersionorfilesHashchangesSimplified implementation (
LintPlugin.ts):Before:
After:
How it was tested
Impacted documentation
None - this is an internal implementation change that does not affect the public API or user-facing behavior.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.