fix: resolve dump_update failures due to DataFrame empty check, date filter, and NaT handling#2147
Open
digital-wizard48 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…filter, and NaT handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs in
scripts/dump_bin.pythat causeddump_updateto fail:NaT in date column: After converting the date field with
pd.to_datetime(), rows with NaT values (unparseable dates) were retained and caused a'NaT is not in list'error when trying to look up the minimum date index in the calendar list. Fixed by callingdf.dropna(subset=[self.date_field_name])after the conversion in_get_source_data.NaT guard in
get_datetime_index: Added an explicit check for NaT minimum index to provide a clear error message instead of a cryptic list lookup failure.These changes address the errors reported when running:
Fixes #126
This PR was auto-generated by Gittensor bot using Claude AI to fix a reported issue.