Skip to content

feat: add missing CLI arguments for find command with env var fallbacks#356

Merged
karthiknadig merged 1 commit intomainfrom
feature/issue-353
Feb 25, 2026
Merged

feat: add missing CLI arguments for find command with env var fallbacks#356
karthiknadig merged 1 commit intomainfrom
feature/issue-353

Conversation

@karthiknadig
Copy link
Member

Adds CLI arguments to the find command that mirror the JSONRPC server's configure options, with PET_* environment variable fallbacks via clap's env attribute.

Changes

  • Add --conda-executable / PET_CONDA_EXECUTABLE to find
  • Add --pipenv-executable / PET_PIPENV_EXECUTABLE to find
  • Add --poetry-executable / PET_POETRY_EXECUTABLE to find
  • Add --environment-directories / PET_ENVIRONMENT_DIRECTORIES (comma-delimited) to find
  • Add PET_CACHE_DIRECTORY env var fallback to existing --cache-directory on both find and resolve
  • Wire new options through FindOptionscreate_config()Configuration
  • Pass user-provided conda/poetry executables to find_and_report_missing_envs (previously hardcoded to None)
  • Enable clap env feature in Cargo.toml

Fixes #353

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 58.1%
Base Branch Coverage 58.3%
Delta -.2% ❌

Coverage decreased. Please add tests for new code.

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Performance Report (Linux) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 77ms 502ms 78ms -1ms 0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 54.44%
Base Branch Coverage 54.58%
Delta -0.14% ❌

Coverage decreased. Please add tests for new code.

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Performance Report (Windows) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 12ms 15ms 10ms 2ms 20%
Full Refresh 201ms 413ms 181ms 20ms 11%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 58ms 507ms 48ms 10ms
Full Refresh 104ms 29452ms 93ms 11ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig marked this pull request as ready for review February 25, 2026 03:59
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 25, 2026
@karthiknadig karthiknadig merged commit e364131 into main Feb 25, 2026
30 checks passed
@karthiknadig karthiknadig deleted the feature/issue-353 branch February 25, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing CLI arguments for find and resolve commands (with env var fallbacks)

2 participants