feat: validate uv workspace members/excludes and discover parent workspaces (Fixes #290)#352
Draft
karthiknadig wants to merge 1 commit intomainfrom
Draft
feat: validate uv workspace members/excludes and discover parent workspaces (Fixes #290)#352karthiknadig wants to merge 1 commit intomainfrom
karthiknadig wants to merge 1 commit intomainfrom
Conversation
Performance Report (Linux) ➖
Legend
|
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (Windows) ✅
Legend
|
Test Coverage Report (Windows)
Coverage increased! Great work! |
Member
Author
|
@zsol This is my attempt at addressing the TODOs in the |
Performance Report (macOS)
Legend
|
zsol
reviewed
Feb 24, 2026
Contributor
zsol
left a comment
zsol
left a comment
There was a problem hiding this comment.
looks good to me, I had one comment
| for candidate in path.ancestors() { | ||
| /// Walks up from `project_path` looking for a parent workspace that this project belongs to. | ||
| /// Returns the workspace environment if found and the project is a valid member. | ||
| fn find_workspace_for_project(project_path: &Path) -> Option<PythonEnvironment> { |
Contributor
There was a problem hiding this comment.
There's one important edge case here: when the project itself is also a workspace (the pyproject.toml defines a [project] as well as [tool.uv.workspace]).
Maybe we should start from project_path instead of its parent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the TODO items in
pet-uvfor workspace member/exclude validation.Changes
[tool.uv.workspace]membersandexcludefields instead of usingIgnoredAnyis_workspace_member()with glob pattern matching (usingrequire_literal_separatorso*doesn't cross directory boundaries)find_workspace_for_project()to discover workspace rootsglobdependency topet-uvFixes #290
cc @zsol — would appreciate your input since you authored the original
pet-uvworkspace support in #263.