Skip to content

chore: untangle global version of ohno#378

Draft
martintmk wants to merge 1 commit intomainfrom
version-downgrade
Draft

chore: untangle global version of ohno#378
martintmk wants to merge 1 commit intomainfrom
version-downgrade

Conversation

@martintmk
Copy link
Copy Markdown
Member

Recent release of ohno caused cascading issues where any crate in this workspace that depends on it need to release a new version with minor bump.

This was reflected when publishing a new version of http_extensions that transitively depends on templated_uri which caused the following publishing error:

    Updating `CratesIoMirror` index
error: failed to prepare local package for uploading

Caused by:
  failed to select a version for `ohno`.
      ... required by package `templated_uri v0.1.1`
      ... which satisfies dependency `templated_uri = "^0.1.1"` of package `http_extensions v0.3.0 (D:\a\_work\1\s\crates\http_extensions)`
  versions that meet the requirements `^0.3.1` (locked to 0.3.1) are: 0.3.1

  all possible versions conflict with previously selected packages.

The solution is not to depend on workspace-defined version but rather keep the version fixed and only bump when necessary.

Copilot AI review requested due to automatic review settings April 16, 2026 07:29
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (e75f236) to head (f9b42bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         224      224           
  Lines       16134    16134           
=======================================
  Hits        16134    16134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates templated_uri to stop inheriting the workspace ohno version, aiming to prevent cascading releases across the workspace when ohno is bumped.

Changes:

  • Pin templated_uri’s ohno dependency to an explicit version instead of workspace = true.
  • Update Cargo.lock to reflect the resolved ohno version used by templated_uri.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/templated_uri/Cargo.toml Replaces ohno.workspace = true with an explicit ohno dependency version.
Cargo.lock Updates the lockfile entry to match the new templated_uriohno resolution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

data_privacy.workspace = true
http.workspace = true
ohno.workspace = true
ohno = "0.3.1"
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohno = "0.3.1" is a caret requirement (equivalent to ^0.3.1), so it will still allow newer 0.3.x releases. If the goal is to keep the version fixed to avoid cascading bumps, use an exact requirement (e.g. =0.3.1) instead.

Copilot uses AI. Check for mistakes.
data_privacy.workspace = true
http.workspace = true
ohno.workspace = true
ohno = "0.3.1"
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This switches templated_uri to registry ohno (0.3.1) while the workspace still provides a path ohno crate (0.3.2), which creates two ohno versions in the workspace lockfile and can cause confusing duplicate types/traits across crate boundaries. Consider adding a workspace-level [patch.crates-io] ohno = { path = "crates/ohno" } for local development while keeping the published dependency pinned, and ensure templated_uri is released with a new patch version so crates.io consumers can pick up the change.

Copilot uses AI. Check for mistakes.
@martintmk martintmk marked this pull request as draft April 16, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants