Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 224 224
Lines 16134 16134
=======================================
Hits 16134 16134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates templated_uri to stop inheriting the workspace ohno version, aiming to prevent cascading releases across the workspace when ohno is bumped.
Changes:
- Pin
templated_uri’sohnodependency to an explicit version instead ofworkspace = true. - Update
Cargo.lockto reflect the resolvedohnoversion used bytemplated_uri.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/templated_uri/Cargo.toml | Replaces ohno.workspace = true with an explicit ohno dependency version. |
| Cargo.lock | Updates the lockfile entry to match the new templated_uri → ohno resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| data_privacy.workspace = true | ||
| http.workspace = true | ||
| ohno.workspace = true | ||
| ohno = "0.3.1" |
There was a problem hiding this comment.
ohno = "0.3.1" is a caret requirement (equivalent to ^0.3.1), so it will still allow newer 0.3.x releases. If the goal is to keep the version fixed to avoid cascading bumps, use an exact requirement (e.g. =0.3.1) instead.
| data_privacy.workspace = true | ||
| http.workspace = true | ||
| ohno.workspace = true | ||
| ohno = "0.3.1" |
There was a problem hiding this comment.
This switches templated_uri to registry ohno (0.3.1) while the workspace still provides a path ohno crate (0.3.2), which creates two ohno versions in the workspace lockfile and can cause confusing duplicate types/traits across crate boundaries. Consider adding a workspace-level [patch.crates-io] ohno = { path = "crates/ohno" } for local development while keeping the published dependency pinned, and ensure templated_uri is released with a new patch version so crates.io consumers can pick up the change.
Recent release of
ohnocaused cascading issues where any crate in this workspace that depends on it need to release a new version with minor bump.This was reflected when publishing a new version of
http_extensionsthat transitively depends ontemplated_uriwhich caused the following publishing error:The solution is not to depend on workspace-defined version but rather keep the version fixed and only bump when necessary.