Skip to content

[Do no merge] 6.18 kernel test for savic#3369

Open
tiala wants to merge 2 commits intomicrosoft:mainfrom
tiala:savic
Open

[Do no merge] 6.18 kernel test for savic#3369
tiala wants to merge 2 commits intomicrosoft:mainfrom
tiala:savic

Conversation

@tiala
Copy link
Copy Markdown

@tiala tiala commented Apr 24, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 24, 2026 11:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the default OpenHCL kernel package versions used by Flowey’s OpenVMM pipelines, apparently to exercise a custom 6.18 “savic” kernel build.

Changes:

  • Update OPENHCL_KERNEL_DEV_VERSION to 6.18.0.100-savic
  • Update OPENHCL_KERNEL_STABLE_VERSION to 6.18.0.100-savic

pub const OPENHCL_KERNEL_DEV_VERSION: &str = "6.12.52.12";
pub const OPENHCL_KERNEL_STABLE_VERSION: &str = "6.12.52.11";
pub const OPENHCL_KERNEL_DEV_VERSION: &str = "6.18.0.100-savic";
pub const OPENHCL_KERNEL_STABLE_VERSION: &str = "6.18.0.100-savic";
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting both OPENHCL kernel dev and stable versions to the same custom "-savic" string means the resolver will try to download main (Main/Cvm) artifacts from tag rolling-lts/hcl-main/6.18.0.100-savic and dev (Dev/CvmDev) artifacts from rolling-lts/hcl-dev/6.18.0.100-savic. Unless that exact version is published on both channels with matching asset names, this will break default pipeline resolution for Main/Cvm kernels. If this is only for a one-off test, please keep OPENHCL_KERNEL_STABLE_VERSION pointing at the normal main-channel release and use the existing LocalKernel override (or add a dedicated override path/version mechanism) for the savic test run instead of changing global defaults.

Suggested change
pub const OPENHCL_KERNEL_STABLE_VERSION: &str = "6.18.0.100-savic";
pub const OPENHCL_KERNEL_STABLE_VERSION: &str = "6.18.0.100";

Copilot uses AI. Check for mistakes.
@tiala tiala marked this pull request as ready for review April 24, 2026 11:13
@tiala tiala requested a review from a team as a code owner April 24, 2026 11:13
@github-actions
Copy link
Copy Markdown

@tiala tiala force-pushed the savic branch 2 times, most recently from 443c01b to 8370ba2 Compare April 24, 2026 13:33
Copilot AI review requested due to automatic review settings April 24, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants