Add storvsp IDE accelerator support to chipset resources#3344
Draft
moor-coding wants to merge 2 commits intomicrosoft:mainfrom
Draft
Add storvsp IDE accelerator support to chipset resources#3344moor-coding wants to merge 2 commits intomicrosoft:mainfrom
moor-coding wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
moor-coding
commented
Apr 21, 2026
moor-coding
commented
- Introduce StorvspIdeDeviceHandle in storvsp_resources with a stable resource ID, mapping IDE channel/device addressing to SCSI path/target.
- Add StorvspIdeResolver in storvsp that resolves the handle into a StorageDevice::build_ide() call via the standard VMBus device resolution path.
- Remove direct storvsp::StorageDevice::build_ide() construction from dispatch.rs and worker.rs; IDE accelerator channels are now resolved as VMBus device handles alongside other vmbus_devices.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves StorVSP IDE accelerator wiring onto the standard vm_resource / VMBus device-handle resolution path by introducing a dedicated StorvspIdeDeviceHandle resource and resolver, and removing ad-hoc channel offering from worker code paths.
Changes:
- Add
StorvspIdeDeviceHandle(stable resource ID) andStorvspIdeResolverto resolve IDE accelerator channels viaStorageDevice::build_ide(). - Register the new resolver in both OpenVMM and OpenVMM-HCL resolver registries.
- Update OpenVMM, OpenHCL, and Petri construction paths to emit IDE accelerator handles as normal VMBus devices, removing direct channel-offer construction.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| vm/devices/storage/storvsp_resources/src/lib.rs | Introduces the StorvspIdeDeviceHandle resource with a stable ID. |
| vm/devices/storage/storvsp/src/resolver.rs | Adds StorvspIdeResolver to resolve IDE accelerator handles into StorageDevice::build_ide(). |
| petri/src/vm/openvmm/construct.rs | Emits StorVSP IDE accelerator handles alongside IDE emulator configs in Petri VM construction. |
| openvmm/openvmm_resources/src/lib.rs | Registers StorvspIdeResolver for OpenVMM binaries. |
| openvmm/openvmm_entry/src/storage_builder.rs | Adds storage-builder support to generate StorVSP IDE accelerator VMBus handles for IDE HDDs. |
| openvmm/openvmm_core/src/worker/dispatch.rs | Removes direct build_ide() offering for IDE accelerator channels. |
| openhcl/underhill_core/src/worker.rs | Switches Underhill IDE accelerator creation to VMBus device-handle resolution, removing direct channel offering. |
| openhcl/underhill_core/src/dispatch/mod.rs | Drops the _ide_accel_devices retention field now that IDE accel channels come from the general VMBus device list. |
| openhcl/underhill_core/Cargo.toml | Removes the direct storvsp dependency from underhill_core. |
| openhcl/openvmm_hcl_resources/src/lib.rs | Registers StorvspIdeResolver for OpenVMM-HCL binaries. |
| Cargo.lock | Reflects dependency graph updates (removal of storvsp from underhill_core). |
moor-coding
force-pushed
the
storvsp-ide-resourcify
branch
from
fbc8674 to
8bf9a78
Compare
- Introduce StorvspIdeDeviceHandle in storvsp_resources with a stable resource ID, mapping IDE channel/device addressing to SCSI path/target. - Add StorvspIdeResolver in storvsp that resolves the handle into a StorageDevice::build_ide() call via the standard VMBus device resolution path. - Remove direct storvsp::StorageDevice::build_ide() construction from dispatch.rs and worker.rs; IDE accelerator channels are now resolved as VMBus device handles alongside other vmbus_devices. - Remove storvsp crate dependency from underhill_core (no longer directly referenced).
- Validate IDE channel_id/device_id (0..=1) in StorvspIdeResolver - Replace assert! with anyhow::ensure! for untrusted VTL2 config in Underhill - Add missing .await on disk_open() in storage_builder
moor-coding
force-pushed
the
storvsp-ide-resourcify
branch
from
8bf9a78 to
73d2848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.