fix: add try/catch around getConsoleProcessList in conpty_console_list_agent #886
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_agent The conpty_console_list_agent.js is forked as a child process to call Win32 AttachConsole and retrieve the console process list for a given shell PID. When the shell process has already exited, AttachConsole fails and throws an unhandled Error, crashing the forked process. In environments like Vitest that monitor child process exits, this crash surfaces as an unhandled error that fails the entire test run even when all tests pass. This adds a try/catch that falls back to returning just the shell PID (matching the existing timeout fallback behavior in windowsPtyAgent.ts) when AttachConsole fails. Also adds a test that verifies the agent handles a dead PID gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
conpty_console_list_agent.jsis forked as a child process to call Win32AttachConsoleand retrieve the console process list for a given shell PID. When the shell process has already exited,AttachConsolefails and throws an unhandledError, crashing the forked process.In environments like Vitest that monitor child process exits, this crash surfaces as an unhandled error that fails the entire test run even when all tests pass.
This adds a
try/catchthat falls back to returning just the shell PID (matching the existing timeout fallback behavior inwindowsPtyAgent.ts) whenAttachConsolefails. Also adds a test that verifies the agent handles a dead PID gracefully.