Rename datapath callback types for transport generalization#6070
Open
guhetier wants to merge 2 commits into
Open
Rename datapath callback types for transport generalization#6070guhetier wants to merge 2 commits into
guhetier wants to merge 2 commits into
Conversation
guhetier
force-pushed
the
guhetier/rename_datapath_types
branch
from
37280b8 to
73f7864
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6070 +/- ##
==========================================
- Coverage 85.93% 85.66% -0.28%
==========================================
Files 60 60
Lines 18798 18798
==========================================
- Hits 16155 16103 -52
- Misses 2643 2695 +52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
guhetier
force-pushed
the
guhetier/rename_datapath_types
branch
from
73f7864 to
2939c25
Compare
The binding trace events refer to the socket object generically, not specifically a UDP socket. Rename for clarity since bindings can now use different transport types (UDP, TCP, RDMA). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename datapath callback type names for consistency: - CXPLAT_UDP_DATAPATH_CALLBACKS -> CXPLAT_DATAPATH_DGRAM_CALLBACKS - CXPLAT_TCP_DATAPATH_CALLBACKS -> CXPLAT_DATAPATH_CONN_CALLBACKS Variable/field names (UdpCallbacks, TcpCallbacks, UdpHandlers, TcpHandlers) are kept as-is since they are used in transport-specific contexts where the protocol is known. The type naming reflects the transport model (datagram vs connection- oriented) rather than specific protocols (UDP/TCP), since RDMA RC is connection-oriented but not a stream. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
guhetier
force-pushed
the
guhetier/rename_datapath_types
branch
from
2939c25 to
cb073b4
Compare
guhetier
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename datapath callback types to make them more generic based on datagram or connection-oriented transport, since MsQuic is going to support other transports than UDP/TCP.
Testing
CI
Documentation
N/A, the types are internal