fix: recover from driver panic on GEOGRAPHY/GEOMETRY columns#704
Open
dlevy-msft-sql wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: recover from driver panic on GEOGRAPHY/GEOMETRY columns#704dlevy-msft-sql wants to merge 1 commit intomicrosoft:mainfrom
dlevy-msft-sql wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The go-mssqldb driver panics when calling ColumnTypes() for GEOGRAPHY/GEOMETRY types (type 240). Wrap the call with panic recovery to return an error instead of crashing.
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sqlcmd crashes with a panic when selecting NULL for GEOGRAPHY or GEOMETRY data types:
Root Cause
The go-mssqldb driver panics in
makeGoLangScanTypewhen encountering type 240 (GEOGRAPHY/GEOMETRY). Therows.ColumnTypes()call propagates this panic up, crashing sqlcmd.Code Change
Added
safeColumnTypes()wrapper that uses defer/recover to catch the panic and convert it to an error:Testing
go build ./...TestSafeColumnTypesRecoversPanicpassesTestQueryTimeoutandTestQueryServerPropertyReturnsColumnNamepass with live databaseFixes #553