Conversation
| make build-packages SRPM_PACK_LIST="hello_world_demo" -j$(nproc) | ||
|
|
||
| # Clean up Mariner workspace, and docker image and container. This requires root privileges | ||
| sudo ./CBL-MarinerTutorials/mariner-docker-builder.sh --mariner_dir /path/to/CBL-Mariner -c |
There was a problem hiding this comment.
Just curious, can the -c be placed anywhere, or does it have a specific position in the arguments list?
There was a problem hiding this comment.
No, it has to be specifically at the end, that's why adding this in README
There was a problem hiding this comment.
I don't see any mention in the comment itself, so one could easily not realize -c must be placed at the end of the argument list.
And I do wonder if the option should be handled differently so the placement is flexible for the user, or it is at a consistent spot relative to other shorthand arguments like -i, which comes immediately after ./CBL-MarinerTutorials/mariner-docker-builder.sh. It can be hard to keep track that -i should come at the start and -c should be at the end of any user invocation
christopherco
left a comment
christopherco
left a comment
There was a problem hiding this comment.
Requesting for the explicit mention in the documentation of the quirk that -c must be placed at the end of the argument list
2 participants
Add an example on how to use cleanup option in README