fix: strip 'skills/' prefix in _collect_bare_skill to prevent double nesting#734
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: strip 'skills/' prefix in _collect_bare_skill to prevent double nesting#734Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…nesting When a dependency has virtual_path='skills/javascript-typescript-jest', the bare skill collector was producing 'skills/skills/javascript-typescript-jest/' instead of 'skills/javascript-typescript-jest/'. Fixes microsoft#719.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a dependency has
virtual_path='skills/javascript-typescript-jest', the bare skill collector in_collect_bare_skillwas producing output paths likeskills/skills/javascript-typescript-jest/SKILL.mdinstead ofskills/javascript-typescript-jest/SKILL.md.This happens because the slug (derived from
virtual_path) already contains theskills/prefix, and the code unconditionally prepends anotherskills/to the output path.Fix
Strip the
skills/prefix from the slug before prependingskills/in the output path:Test added
test_virtual_path_with_skills_prefix_no_double_nestingintests/unit/test_plugin_exporter.pycovers this exact bug scenario.Fixes #719.