Update AzureAuth to 0.9.6 for macOS broker support#148
Draft
krubenok wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft status / blocker
This is intentionally a draft. AzureAuth 0.9.6 contains macOS broker support, but local validation shows the Azure DevOps PAT path does not work yet with the built-in ADO client registration.
The failing path is:
node packages/node-azureauth/scripts/azureauth.cjs ado pat \ --mode broker \ --organization outlookweb \ --display-name local-macos-broker-test \ --prompt-hint "Authenticate to outlookweb for local macOS broker test" \ --scope vso.packaging_write \ --output json \ --timeout 30 \ --verbosity debugThat fails in broker token acquisition with WAM error
-51411,ApiContractViolation, and AADSTS50011. The narrower AAD repro using AzureAuth's built-in Azure DevOps parameters also fails with the same51411error:node packages/node-azureauth/scripts/azureauth.cjs aad \ --client 872cd9fa-d31f-45e0-9eab-6e460a02d1f1 \ --tenant 72f988bf-86f1-41af-91ab-2d7cd011db47 \ --scope 499b84ac-1321-427f-aa17-267ca6975798/.default \ --mode broker \ --prompt-hint "Test Azure DevOps client broker redirect" \ --output none \ --timeout 1 \ --verbosity debugAzureAuth 0.9.6 uses the macOS broker redirect URI
msauth.com.msauth.unsignedapp://auth. That redirect URI needs to be added to the app registration for client872cd9fa-d31f-45e0-9eab-6e460a02d1f1before this PR can be validated end to end.Validation
yarn workspace azureauth testyarn prettier --check packages/node-azureauth/README.md packages/ado-npm-auth/README.md packages/yarn-plugin-ado-auth/README.mdnode packages/node-azureauth/scripts/azureauth.cjs --versionreports0.9.6.0ado pat --mode web; broker path is blocked by the app-registration redirect URI issue above.