This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Implemented tests for imageboard#40
Open
SamuelMarks wants to merge 4 commits intomicrosoft:masterfrom
SamuelMarks:imageboard_tests
Open
Implemented tests for imageboard#40SamuelMarks wants to merge 4 commits intomicrosoft:masterfrom SamuelMarks:imageboard_tests
SamuelMarks wants to merge 4 commits intomicrosoft:masterfrom
SamuelMarks:imageboard_tests
Conversation
Member
|
Hey @SamuelMarks thanks for taking this on. I think the correct thing to do was just to use For the second question, I don't think we had a specific preference. If you have a better idea in mind, I think we'd welcome it. What were you thinking? |
Author
|
@DanielRosenwasser: No worries. Okay, it's now ready to merge. Would you like me to squash all my commits into one? |
Member
|
@SamuelMarks no I think this is fine, though, I think other projects relied on the same node.d.ts. @mhegazy any idea about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this isn't [yet] ready for being merged. PR created to facilitate discussion.
Questions:
typings, because that's what you've been doing. However, I've also added atsd.json, so now people can get the package manager to populate that directory (like they wouldnode_modules). Should I addtypingsto.gitignore?npm testnow does amocha --compilers ts:typescript-require -u exports -R spec tests/test_*.ts. Is that the approach you prefer?Improving test coverage once these initial tests are in the folder should be trivial.