Skip to content

Fix 'occured' -> 'occurred' typo in sanddance-app download click-handler comment #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix 'occured' -> 'occurred' typo in sanddance-app download click-handler comment #816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sanddance-app/src/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function downloadData(data: any, fileName: string) {
const blob = dataURIToBlob(data);
a.href = URL.createObjectURL(blob);
// we must revoke the object URL,
// since we can't know when the download occured, we have to attach it on the click handler..
// since we can't know when the download occurred, we have to attach it on the click handler..
a.onclick = () => {
// ..and to wait a frame
requestAnimationFrame(() => URL.revokeObjectURL(a.href));
Expand Down