Skip to content

Update code to support node-16#49

Draft
fgodino wants to merge 1 commit intomicrosoft:masterfrom
fgodino:node-16
Draft

Update code to support node-16#49
fgodino wants to merge 1 commit intomicrosoft:masterfrom
fgodino:node-16

Conversation

@fgodino
Copy link
Copy Markdown
Contributor

@fgodino fgodino commented Jun 23, 2022

No description provided.

@acoroleu-tempus
Copy link
Copy Markdown

@Mmdixon can we get your review on this and build binaries? Thanks!

@acoroleu-tempus
Copy link
Copy Markdown

any updates on this? @Mmdixon

@Mmdixon
Copy link
Copy Markdown
Contributor

Mmdixon commented Sep 23, 2022

@acoroleu-tempus Looks like the build failed because some of the dependencies are getting old and no longer hosted on the build servers (e.g. .NET core 2.1), I'll fix the build then get integration running again for this PR.

@acoroleu-tempus
Copy link
Copy Markdown

@Mmdixon any progress here?

@acoroleu-tempus
Copy link
Copy Markdown

@Mmdixon we'd like to upgrade our code to node16, this dependency is blocking us from doing so. Have you got time to review this PR? Thanks for your time

@Mmdixon
Copy link
Copy Markdown
Contributor

Mmdixon commented Nov 13, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@Mmdixon Mmdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should drop the package-lock.json changes.

@acoroleu-tempus
Copy link
Copy Markdown

acoroleu-tempus commented Apr 3, 2023

the package-lock.json changes are needed since node 16 updated the schema for this file. which specific changes should I drop? @Mmdixon

@acoroleu-tempus
Copy link
Copy Markdown

@Mmdixon any update on this? Thanks

This was referenced Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants