Update SHA validation: Tighten and align grep pattern with script output#2905
Open
vijaysaayi wants to merge 1 commit intomainfrom
Open
Update SHA validation: Tighten and align grep pattern with script output#2905vijaysaayi wants to merge 1 commit intomainfrom
vijaysaayi wants to merge 1 commit intomainfrom
Conversation
Update validation scripts and workflow to use 'SHA VALIDATION PASSED' and 'SHA VALIDATION FAILED' consistently across both the PHP and .NET validation scripts, and align the workflow grep patterns to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Shi1810
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validate-shaworkflow grepped for^PASSED$but the scripts used inconsistent output messages. This PR aligns all scripts and the workflow to useSHA VALIDATION PASSED/SHA VALIDATION FAILED.Changes
build/scripts/validate-dotnet-sha.sh— outputSHA VALIDATION PASSED/SHA VALIDATION FAILEDbuild/scripts/validate-php-sha.sh— outputSHA VALIDATION PASSED/SHA VALIDATION FAILED.github/workflows/validate-sha.yaml— grep forSHA VALIDATION PASSEDin both PHP and .NET stepsTesting
Both scripts were run locally against
images/constants.ymlwith valid and tampered SHAs.SHA VALIDATION PASSEDSHA VALIDATION FAILEDSHA VALIDATION PASSEDSHA VALIDATION FAILED - SHA256 mismatches detected!The workflow also triggers on this PR since it touches
build/scripts/validate-*-sha.sh.