fix(infra): delegate Container Apps subnet + stop masking failed terraform apply (PROD RECOVERY)#430
Merged
Merged
Conversation
…aform apply PRODUCTION RECOVERY. Two bugs combined to take down the production Container Apps environment during the private-topology redeploy (#429): 1. The container_apps subnet had no delegation, so creating the VNet-integrated Container Apps environment failed with: ManagedEnvironmentSubnetDelegationError: The subnet of the environment must be delegated to the service 'Microsoft.App/environments'. Add the required delegation (Microsoft.App/environments + Microsoft.Network/virtualNetworks/subnets/join/action). 2. The deploy step ran 'terraform apply ... | tee' inside an if-condition with no pipefail, so the pipeline reported tee's (success) exit status and MASKED the failed apply. The old environment had already been destroyed, so the job went green while production was left with no environment and no container apps. Capture terraform's real exit code via PIPESTATUS so a failed apply fails the job instead of silently reporting success. With the delegation in place the environment can be (re)created, and the PIPESTATUS fix ensures any future apply failure surfaces instead of corrupting the environment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRODUCTION RECOVERY for the outage caused by the #429 private-topology redeploy.
Root causes
Fixes
Merging triggers a production redeploy that recreates the environment + apps with the corrected subnet delegation.