Add SimplifiedLayerNormToRMSNorm surgery#2348
Add SimplifiedLayerNormToRMSNorm surgery#2348unnim-qti wants to merge 4 commits intomicrosoft:mainfrom
Conversation
|
@unnim-qti can you please update this PR? We are going to release new Olive version this Friday and this PR will be included |
63ebd29 to
bd06441
Compare
|
Why not make this a rewrite rule, out of curiosity? |
I considered a rewrite rule, but this transform isn’t purely structural.
|
|
Handling value infos and optional output handling should be straightforward with the onnxscript rewriter. I wonder if you saw any blockers? |
|
I didn’t see any hard blockers in the rewriter, but I followed the existing pattern SimplifiedLayerNormToL2Norm, which use ProtoSurgeon to handle variant‑specific wiring, and optional outputs explicitly. Given that precedent and the comparable complexity here, I kept this transform in the ProtoSurgeon style for the consistency. |
Describe your changes
Checklist before requesting a review
lintrunner -a(Optional) Issue link