expands tests to run on osx-arm64 and linux-x64#638
Open
Conversation
added 30 commits
April 4, 2026 23:06
added 4 commits
April 15, 2026 00:23
… prathikrao/add-macos-tests
added 3 commits
April 15, 2026 15:12
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Expands CI test execution across additional OS/architecture combos (notably macOS arm64 and Linux x64) by splitting SDK build and test steps into dedicated Azure Pipelines templates and wiring new test stages/jobs into the main packaging pipeline.
Changes:
- Add new Azure Pipelines test-step templates for C#, JS, Python, and Rust SDKs and move test execution out of build templates.
- Update packaging pipeline to run SDK tests on win-x64, linux-x64, and osx-arm64 (with JS linux-x64 currently commented out).
- Remove legacy GitHub Actions SDK build workflows in favor of Azure DevOps orchestration.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/js/test/detail/modelLoadManager.test.ts | Increases Mocha timeout to reduce macOS CI flakiness from slow network fetches. |
| .pipelines/templates/test-rust-steps.yml | New reusable Rust SDK test steps (extract native bits, install toolchain, run unit/integration tests). |
| .pipelines/templates/test-python-steps.yml | New reusable Python SDK test steps (select Python arch, install wheels/deps, run pytest). |
| .pipelines/templates/test-js-steps.yml | New reusable JS SDK test steps (install deps, place native bits, build, run tests). |
| .pipelines/templates/test-cs-steps.yml | New reusable C# SDK test steps (NuGet config, restore/build/test). |
| .pipelines/templates/build-rust-steps.yml | Removes Rust test execution from build template (now in test template). |
| .pipelines/templates/build-python-steps.yml | Adjusts ORT packages on Linux; removes Python test execution from build template. |
| .pipelines/templates/build-js-steps.yml | Removes JS test execution from build template. |
| .pipelines/templates/build-cs-steps.yml | Removes C# test execution from build template. |
| .pipelines/templates/build-core-steps.yml | Expands condition for restoring FLC tests to include linux-x64 and osx-x64 flavors. |
| .pipelines/foundry-local-packaging.yml | Adds SDK test stages/jobs for standard + WinML; adds osx-arm64 pool usage; updates job display names; comments out JS linux test job. |
| .github/workflows/foundry-local-sdk-build.yml | Removes legacy SDK build orchestration workflow. |
| .github/workflows/build-rust-steps.yml | Removes legacy GitHub Actions Rust SDK workflow. |
| .github/workflows/build-python-steps.yml | Removes legacy GitHub Actions Python SDK workflow. |
| .github/workflows/build-js-steps.yml | Removes legacy GitHub Actions JS SDK workflow. |
| .github/workflows/build-cs-steps.yml | Removes legacy GitHub Actions C# SDK workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mac/linux test coverage for FL Core & SDK and retires github actions macos tests. Also removes our reliance on PATs.
NOTE: The Linux JS test job is currently disabled due to intermittent SSL errors when running get_model_list. This issue is under investigation.