Skip to content

Misc. improvements to collaborative text controls and text-editor example application#27141

Open
Josmithr wants to merge 12 commits intomicrosoft:mainfrom
Josmithr:text-editor/display-all-views
Open

Misc. improvements to collaborative text controls and text-editor example application#27141
Josmithr wants to merge 12 commits intomicrosoft:mainfrom
Josmithr:text-editor/display-all-views

Conversation

@Josmithr
Copy link
Copy Markdown
Contributor

@Josmithr Josmithr commented Apr 23, 2026

  • Removes the hardcoded headers from above exported text controls in react and quill-react - this isn't something we should be exporting as a part of our library. Users can add their own headings as needed.
  • Updates exported text controls to ensure their entire editor space is clickable and causes the editor to be selected (previously, you could only accomplish this by clicking on a line that contained text, or the first line only if empty).
  • Updates quill-based editor components to perform necessary cleanup on unmount.

Also updates the text-editor app to display all 3 editors at once, rather than only one at a time. Each is displayed as a collapsable card.

image

Copilot AI review requested due to automatic review settings April 23, 2026 17:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the collaborative text editor controls and updates the text-editor example to better demonstrate multiple editor implementations side-by-side.

Changes:

  • Removed hardcoded <h2> headings from exported editor views (React textarea, Quill plain, Quill formatted).
  • Improved click-to-focus behavior so clicking the editor container focuses the underlying editor (and added cursor: text where applicable).
  • Updated the text-editor example to show all three editor variants simultaneously per user, using collapsible cards.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
packages/framework/react/src/text/plain/plainTextView.tsx Removes hardcoded heading; adds container click-to-focus for the textarea.
packages/framework/quill-react/src/plain/quillView.tsx Removes hardcoded heading; adds container click-to-focus and text cursor styling.
packages/framework/quill-react/src/formatted/quillFormattedView.tsx Removes hardcoded heading; adds container click-to-focus and text cursor styling.
examples/data-objects/text-editor/src/app.tsx Reworks example layout to render all editors at once with collapsible cards per user.

Comment thread examples/data-objects/text-editor/src/app.tsx
Comment thread examples/data-objects/text-editor/src/app.tsx
Comment thread examples/data-objects/text-editor/src/app.tsx Outdated
@Josmithr Josmithr requested review from a team, CraigMacomber and brrichards April 23, 2026 18:16
Comment thread examples/data-objects/text-editor/src/app.tsx
Comment thread examples/data-objects/text-editor/src/app.tsx Outdated
Copy link
Copy Markdown
Contributor

@brrichards brrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small nit, but changes look good to me!

Josmithr and others added 2 commits April 23, 2026 15:26
Co-authored-by: brrichards <brrichards@microsoft.com>
@Josmithr Josmithr enabled auto-merge (squash) April 23, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants