Misc. improvements to collaborative text controls and text-editor example application#27141
Open
Josmithr wants to merge 12 commits intomicrosoft:mainfrom
Open
Misc. improvements to collaborative text controls and text-editor example application#27141Josmithr wants to merge 12 commits intomicrosoft:mainfrom
text-editor example application#27141Josmithr wants to merge 12 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the collaborative text editor controls and updates the text-editor example to better demonstrate multiple editor implementations side-by-side.
Changes:
- Removed hardcoded
<h2>headings from exported editor views (React textarea, Quill plain, Quill formatted). - Improved click-to-focus behavior so clicking the editor container focuses the underlying editor (and added
cursor: textwhere applicable). - Updated the
text-editorexample to show all three editor variants simultaneously per user, using collapsible cards.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/framework/react/src/text/plain/plainTextView.tsx | Removes hardcoded heading; adds container click-to-focus for the textarea. |
| packages/framework/quill-react/src/plain/quillView.tsx | Removes hardcoded heading; adds container click-to-focus and text cursor styling. |
| packages/framework/quill-react/src/formatted/quillFormattedView.tsx | Removes hardcoded heading; adds container click-to-focus and text cursor styling. |
| examples/data-objects/text-editor/src/app.tsx | Reworks example layout to render all editors at once with collapsible cards per user. |
brrichards
reviewed
Apr 23, 2026
brrichards
reviewed
Apr 23, 2026
brrichards
approved these changes
Apr 23, 2026
Contributor
brrichards
left a comment
There was a problem hiding this comment.
Left a small nit, but changes look good to me!
Co-authored-by: brrichards <brrichards@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reactandquill-react- this isn't something we should be exporting as a part of our library. Users can add their own headings as needed.quill-based editor components to perform necessary cleanup on unmount.Also updates the
text-editorapp to display all 3 editors at once, rather than only one at a time. Each is displayed as a collapsable card.