fix(brainstorm): lint and type fixes#1856
Draft
tylerbutler wants to merge 1 commit intomicrosoft:mainfrom
Draft
Conversation
- Update tsconfig jsx from "react" to "react-jsx" (React 19 automatic transform) - Convert == to === and != to !== for strict equality - Convert ternary expressions to nullish coalescing (??) - Replace non-null assertions with ?? "" fallbacks - Add .catch() handlers for floating promises - Fix import ordering per import-x/order - Apply consistent-type-imports (separate type imports) - Use codePointAt() instead of charCodeAt() 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"react"to"react-jsx"(React 19 automatic transform)==to===and!=to!==for strict equality??)!) with?? ""fallbacks.catch()handlers for floating promisescodePointAt()instead ofcharCodeAt()These are independently valid code improvements, split out from the eslint-config-fluid adoption PR.
Test plan
npm run compilein brainstorm has no new TypeScript errors