Skip to content

Fix Windows multiline test yamls #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zanejohnson-azure wants to merge 1 commit into
base: ci_prod
Choose a base branch
from
Open

Fix Windows multiline test yamls #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions test/scenario/multiline/dotnet-win.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,9 @@ spec:
- name: dotnet-win-scripts-volume
configMap:
name: dotnet-win-test-scripts
nodeSelector:
kubernetes.io/os: windows
kubernetes.io/arch: amd64
containers:
- name: dotnet-win
image: mcr.microsoft.com/powershell:lts-nanoserver-1809
image: mcr.microsoft.com/powershell:lts-nanoserver-ltsc2022
volumeMounts:
- mountPath: C:\dotnet-win-test-scripts
name: dotnet-win-scripts-volume
Expand Down
5 changes: 1 addition & 4 deletions test/scenario/multiline/golang-win.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,9 @@ spec:
- name: golang-win-scripts-volume
configMap:
name: golang-win-test-scripts
nodeSelector:
kubernetes.io/os: windows
kubernetes.io/arch: amd64
containers:
- name: golang-win
image: mcr.microsoft.com/powershell:lts-nanoserver-1809
image: mcr.microsoft.com/powershell:lts-nanoserver-ltsc2022
volumeMounts:
- mountPath: C:\golang-win-test-scripts
name: golang-win-scripts-volume
Expand Down
5 changes: 1 addition & 4 deletions test/scenario/multiline/java-win.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,9 @@ spec:
- name: java-win-scripts-volume
configMap:
name: java-win-test-scripts
nodeSelector:
Copy link
Copy Markdown
Contributor

@rashmichandrashekar rashmichandrashekar May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought all aks windows nodes had these labels. is that not right?

Copy link
Copy Markdown
Contributor Author

@zanejohnson-azure zanejohnson-azure May 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this nodeSelector appeared twice in the yaml, remove one of the two @rashmichandrashekar

  nodeSelector:
    kubernetes.io/os: windows
    kubernetes.io/arch: amd64
  volumes:
  - name: dotnet-win-scripts-volume
    configMap:
      name: dotnet-win-test-scripts
  nodeSelector:
    kubernetes.io/os: windows
    kubernetes.io/arch: amd64

kubernetes.io/os: windows
kubernetes.io/arch: amd64
containers:
- name: java-win
image: mcr.microsoft.com/powershell:lts-nanoserver-1809
image: mcr.microsoft.com/powershell:lts-nanoserver-ltsc2022
volumeMounts:
- mountPath: C:\java-win-test-scripts
name: java-win-scripts-volume
Expand Down
5 changes: 1 addition & 4 deletions test/scenario/multiline/python-win.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,9 @@ spec:
- name: python-win-scripts-volume
configMap:
name: python-win-test-scripts
nodeSelector:
kubernetes.io/os: windows
kubernetes.io/arch: amd64
containers:
- name: python-win
image: mcr.microsoft.com/powershell:lts-nanoserver-1809
image: mcr.microsoft.com/powershell:lts-nanoserver-ltsc2022
volumeMounts:
- mountPath: C:\python-win-test-scripts
name: python-win-scripts-volume
Expand Down
Loading