fix: address PR review comments on workflow files#135
Open
Harmanpreet-Microsoft wants to merge 1 commit intomicrosoft:devfrom
Open
fix: address PR review comments on workflow files#135Harmanpreet-Microsoft wants to merge 1 commit intomicrosoft:devfrom
Harmanpreet-Microsoft wants to merge 1 commit intomicrosoft:devfrom
Conversation
- azure-dev.yml: Export derived RG name as AZURE_RESOURCE_GROUP (not RESOURCE_GROUP) so azd provision picks up the correct resource group when vars.AZURE_RESOURCE_GROUP is empty. - azd-template-validation.yml: Use secrets.AZURE_PRINCIPAL_ID instead of secrets.AZURE_CLIENT_ID as fallback for AZURE_PRINCIPAL_ID. Client ID is not the SP object ID and causes RBAC assignment failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Harmanpreet-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801 and
toherman-msft
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
azure-dev.yml: Export derived RG name as AZURE_RESOURCE_GROUP (not RESOURCE_GROUP) so azd provision picks up the correct resource group when vars.AZURE_RESOURCE_GROUP is empty.
azd-template-validation.yml: Use secrets.AZURE_PRINCIPAL_ID instead of secrets.AZURE_CLIENT_ID as fallback for AZURE_PRINCIPAL_ID. Client ID is not the SP object ID and causes RBAC assignment failures.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information