Enable AOT running of UnitTests; Migrate UnitTests from XUnit to MSTest Framework #2257
Open
kythant wants to merge 69 commits intostaging/3.0from
Open
Enable AOT running of UnitTests; Migrate UnitTests from XUnit to MSTest Framework #2257kythant wants to merge 69 commits intostaging/3.0from
kythant wants to merge 69 commits intostaging/3.0from
Conversation
kythant
changed the title
This reverts commit 45c456d.
Sergio0694
approved these changes
Feb 23, 2026
Comment on lines
16
to
20
| <!-- Temporary workaround, remove when https://github.com/dotnet/sdk/pull/41936 is available in the .NET SDK --> | ||
| <ItemGroup> | ||
| <CompilerVisibleProperty Include="CsWinRTUseWindowsUIXamlProjections" /> | ||
| <RuntimeHostConfigurationOption Include="CSWINRT_USE_WINDOWS_UI_XAML_PROJECTIONS" | ||
| Value="$(CsWinRTUseWindowsUIXamlProjections)" | ||
| Trim="true" /> | ||
| <RuntimeHostConfigurationOption Include="CSWINRT_USE_WINDOWS_UI_XAML_PROJECTIONS" Value="$(CsWinRTUseWindowsUIXamlProjections)" Trim="true" /> | ||
| </ItemGroup> |
Member
There was a problem hiding this comment.
That should be available now, can we remove this workaround?
manodasanW
reviewed
Feb 23, 2026
src/cswinrt.slnx
Outdated
| @@ -228,7 +200,6 @@ | |||
| </Project> | |||
| <Project Path="Tests/UnitTest/UnitTest.csproj"> | |||
| <BuildDependency Project="Perf/IIDOptimizer/IIDOptimizer.csproj" /> | |||
Member
There was a problem hiding this comment.
I assume you haven't merged in changes from staging/3.0 yet.
manodasanW
reviewed
Feb 23, 2026
manodasanW
reviewed
Feb 23, 2026
manodasanW
reviewed
Feb 23, 2026
|
|
||
| TestObject.EnumStructsProperty = null; | ||
| Assert.Empty(TestObject.EnumStructsProperty); | ||
| Assert.IsTrue(TestObject.EnumStructsProperty.SequenceEqual(null)); |
Member
There was a problem hiding this comment.
To confirm, does this work as expected?
Author
There was a problem hiding this comment.
I believe so. TestObject.EnumStructsProperty showed up as {0} so it wasn't completely a nullptr. Is this a mistake on the test code end?
Member
There was a problem hiding this comment.
Showing up as {} / empty is expected.
Author
There was a problem hiding this comment.
Right but the pointer itself isn't null right? It is pointing to a structure that is empty
manodasanW
reviewed
Feb 23, 2026
| var vector = TestObject.GetUriVectorAsIInspectableVector(); | ||
| var uriVector = vector.Cast<Uri>(); | ||
| var first = uriVector.First(); | ||
| Assert.Equal(vector, uriVector); | ||
| // Assert the sequences are equivalent | ||
| Assert.IsTrue(vector.Cast<Uri>().SequenceEqual(uriVector)); // [2] |
Member
There was a problem hiding this comment.
Is the comment indicating the size?
manodasanW
reviewed
Feb 23, 2026
This reverts commit 2332a6f.
….com/microsoft/CsWinRT into user/kythant/MSTestMigrateOnboardCI3
kythant
force-pushed
the
user/kythant/MSTestMigrate
branch
from
949781f to
f06001d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.