feat: add support for storing access tokens in password-store#68
Conversation
|
Hello! Thanks for the contribution! I think it's good! Password managers are good so happy to support more. It looks good, just a couple of docs/help text to sync:
I'll consider the unifiying of the cli for password managers for a bit later as it's a breaking change and I'd want to test it with my agent first. same for the refs. but I think they're both a good idea can you do the follow ups for the docs/help text? |
|
Thanks taking the time to review this draft and for the valuable feedback, @mexcool. I'm happy to hear that you see value in the proposed changes and have already followed up with the changes you requested. Is that what you had in mind? |
Co-authored-by: Asier <mexcool@users.noreply.github.com>
|
Thanks for reviewing, commented, approving, and merging the feature suggestion, @mexcool, very much appreciated 💯 Happy to see that 0.4.0 is also already published! 🎉 |
I use passwordstore to store my passwords and was wondering whether you'd be willing to accept adding support for it.
N.B.: All code in this PR was written using claude-code, while I have tested that the changes work as expected I'd do another more thorough review if there is interest in this change.
Going over the code I wonder if support for password manager could be improved, e.g. by combining the
--1passwordand--passoptions into one, e.g.--password-manager 1passwordand whether in the config.ymlop_refandpass_refcould be combined intopassword_manager_refgiven that the value has an identifying "scheme" prefix, e.g.op://.What are your thoughts on this, @mexcool? 🙂