Remove dead modules, dead code in showcase, and stale test helpers#96
Merged
Remove dead modules, dead code in showcase, and stale test helpers#96
Conversation
Audit pass over src/, examples/, and tests/ for code that has no callers anywhere. Found: * src/style/renderer.zig (177 lines) — defines RenderContext, stripAnsi, hasAnsi, truncate. Zero references in src, examples, or tests. The 6 test files that needed an ANSI stripper each rolled their own rather than reusing this. Delete; if anyone needs it later it can come back tied to actual callers. * src/testing/record_replay.zig (372 lines) — Recorder/Player for TUI session capture. No example, no test, no other src file uses it. Speculative API that didn't earn its place. Delete plus drop the four root.zig re-exports. * examples/showcase.zig — renderVerticalBars() built a bar chart whose result was thrown away by an explicit "_ = vertical_box" on line 790. Delete the helper, the call site, and the dead computed binding (~25 lines of code that ran every frame for no visible output). * tests/markdown_tests.zig — orphaned renderMd helper at the top of the file: never called, plus had a latent use-after-free (returned slice from an arena destroyed on function return). Build passes, full test suite passes. No public API removed beyond the two dead modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit pass for code that has no callers anywhere — files were imported nowhere, helpers were defined but never called, computed values were explicitly discarded. Net -584 lines, no behavior change, no public API removed beyond the two dead modules.
What was removed
Audit notes — what was not removed
Test plan