Fix segfaults in new examples (use persistent_allocator)#92
Merged
meszmate merged 1 commit intofeature/examples-batch-7from Apr 23, 2026
Merged
Fix segfaults in new examples (use persistent_allocator)#92meszmate merged 1 commit intofeature/examples-batch-7from
meszmate merged 1 commit intofeature/examples-batch-7from
Conversation
Five of the six new examples crashed with segfaults / bus errors after the first frame because component state (DataTable rows, RichLog entries, ScreenStack stack, ActionRegistry actions, BrailleCanvas cells) was allocated with ctx.allocator — the per-frame arena that resets every render. Switch all per-component state in init() to ctx.persistent_allocator, matching the pattern used by examples/file_browser.zig. Also allocate palette shortcut strings on persistent in action_system since CommandPalette stores them by reference.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five of the six new examples from #91 crashed after the first frame:
Root cause
I initialized component state with `ctx.allocator` — that's the per-frame arena which resets every render. Component internals (array lists of rows, entries, columns, etc.) ended up pointing at freed memory after the first `render()`.
Fix
Switch all long-lived component initialization to `ctx.persistent_allocator`, matching the pattern already used by `examples/file_browser.zig`. Also allocate the palette `shortcut` strings on persistent in `action_system` since `CommandPalette` stores command structs by reference.
Base branch
This PR targets `feature/examples-batch-7` (#91). Once merged there, #91 will have working examples.
Test plan