Skip to content

fix: theme option buttons submit search form#395

Merged
maxulysse merged 1 commit into
mainfrom
copilot/fix-theme-toggle-search-trigger
Jun 13, 2026
Merged

fix: theme option buttons submit search form#395
maxulysse merged 1 commit into
mainfrom
copilot/fix-theme-toggle-search-trigger

Conversation

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Clicking a theme option (Light/Dark/System) navigated to /search because those buttons lacked type="button" and defaulted to type="submit" inside the search <form>.

Change

  • Added type="button" to all three .theme-option buttons in BaseLayout.astro
<!-- before -->
<button class="theme-option" data-theme="light">

<!-- after -->
<button class="theme-option" type="button" data-theme="light">

Copilot AI changed the title fix: prevent theme toggle from triggering search form submission fix: theme option buttons submit search form Jun 13, 2026
Copilot AI requested a review from maxulysse June 13, 2026 08:34
@maxulysse maxulysse marked this pull request as ready for review June 13, 2026 08:35
@maxulysse maxulysse merged commit a283fde into main Jun 13, 2026
4 checks passed
@maxulysse maxulysse deleted the copilot/fix-theme-toggle-search-trigger branch June 13, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants