Don't persist credentials in pages checkout#12
Merged
Conversation
zizmor flags the checkout step in pages.yml for artipacked: without persist-credentials: false, the GitHub token is written into the local git config and could leak via later steps or artifacts. Nothing after the checkout needs git credentials. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
oschwald
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zizmor reports an
artipackedfinding for the checkout step inpages.yml: withoutpersist-credentials: false, the GitHub token is written into the local git config and could leak via later steps or build artifacts. Nothing after the checkout needs git credentials (the job just builds the site and uploads the artifact), so this disables persistence.🤖 Generated with Claude Code