feat: support children in ReferenceManyCount#11272
Closed
louzhedong wants to merge 3 commits into
Closed
Conversation
Author
|
Quick follow-up: I re-checked the branch locally and the targeted tests are still green on my side. The only failing GitHub checks are the Vercel deployment authorizations, which look external to the code change. If you'd like, I can re-run or narrow anything further once there's a maintainer review comment. |
Member
|
Duplicate of #11266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
childrensupport toReferenceManyCountBaseand forwards it through the MUI wrapper so callers can customize the total rendering with existing field components.Implementation details:
RecordContextProviderwith{ id: 'count', total }Tests:
yarn.cmd test-unit packages/ra-core/src/controller/field/ReferenceManyCountBase.spec.tsx --runInBand --watch=falseyarn.cmd test-unit packages/ra-ui-materialui/src/field/ReferenceManyCount.spec.tsx --runInBand --watch=falseyarn.cmd workspace ra-core build