Project cleanup#27
Conversation
Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
pysqlite3 is a defunct project now: redirect others to install the py-sqlite3 package instead, i.e., the module that's distributed with the python language distribution. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
This ignores a lot more autogenerated paths which should not be checked in to :master. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
- Run `I` and `UP` category fixers and resolve all issues not handled via `--unsafe-fixes`. - Run through the remaining safe fixers under the `ALL` meta-category. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
|
|
Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
- Unpack iterables instead of appending one iterable to another iterable (RUF005). - Don't assign values via mutable arguments (dicts, lists) in functions. - Fix a potential SQLite3 injection attack via an f-interpolated string. - Re-raise exceptions using `raise` when possiible to avoid mangling the traceback stack. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
markjdb
left a comment
markjdb
left a comment
There was a problem hiding this comment.
Please don't reformat all of the code, it makes history unreadable for no benefit and gives me a bunch of work to do when rebasing local WIP patches. I don't want to take these "chore" patches.
If you want to make the code compliant to some linter or type checker, please at least include a script so that others can easily lint their changes.
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", | ||
| "Programming Language :: Python :: 3.15", |
There was a problem hiding this comment.
Is there no way to write "3.11 or later"?
| """) | ||
| WHERE tr.result_type = ? | ||
| """, | ||
| (restype.value,), |
There was a problem hiding this comment.
There is no "attack": restype's value is defined within the code itself, and the user invoking bricoler already has control over the db file. Please don't use such language for benign things.
| "-o", | ||
| f"poolname={zfs_pool_name}", | ||
| "-o", | ||
| f"bootfs={zfs_pool_name}", |
There was a problem hiding this comment.
I find this less readable than before.
2 participants
ruff format.