Update src/replicatorg/app/ui/modeling/Tool.java#284
Open
ryancnelson wants to merge 1 commit intomakerbot:masterfrom
Open
Update src/replicatorg/app/ui/modeling/Tool.java#284ryancnelson wants to merge 1 commit intomakerbot:masterfrom
ryancnelson wants to merge 1 commit intomakerbot:masterfrom
Conversation
Fix apparent bug where the code has "if not shiftkey down, then rotate-view" "if shiftkey down, then also, rotate-view" ... then later, there's a case statement for "TRANSLATE_VIEW", which isn't referenced anywhere else, ever. changing this enables an otherwise non-existent "pan" mode in the UI.
erinzm
added a commit
to replicatorg/ReplicatorG
that referenced
this pull request
Aug 18, 2015
Thanks to @ryancnelson for the tip. (makerbot/ReplicatorG#284) The logic was setting ROTATE_VIEW for *everything* unconditionally, this changes it such that: * on a mac, when shift is held down and a mouse1 drag happens, it sets TRANSLATE_VIEW * on a !mac, when a button3 drag happens, it sets TRANSLATE_VIEW.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix apparent bug where the code has
"if not shiftkey down, then rotate-view"
"if shiftkey down, then also, rotate-view" ...
then later, there's a case statement for "TRANSLATE_VIEW", which isn't referenced anywhere else, ever.
changing this enables an otherwise non-existent "pan" mode in the UI.