Rework the magnon CLI . And fix magnon frequency error. #84
Open
mailhexu wants to merge 11 commits into
Open
Conversation
- Add --spin-conf CLI option and spin_conf TOML parameter for specifying magnetic moments - Refactor: extract prepare_magnon_from_params to reduce code duplication - Fix create_plot_script to write to correct output directory - Add magnon_theory.md documentation - Add examples directory with scripts and config files - Add comprehensive tests for magnon functionality
- Set default=True for --no-Jiso, --no-Jani, --no-DMI, --no-SIA CLI args to ensure all interactions are enabled by default - Remove path prepending for spin_conf_file and uz_file; paths are now relative to current working directory, not TB2J results path - Add combined J tensor output in exchange.out showing J = Jiso*I + DMI + Jani - Document combined tensor formula and provide verified example in docs - Fix type hints for Optional[str] in MagnonParameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.