Made weak reference to shutdown BT stack, to avoid linking it if not needed#322
Open
chipguyhere wants to merge 1 commit intom5stack:masterfrom
Open
Made weak reference to shutdown BT stack, to avoid linking it if not needed#322chipguyhere wants to merge 1 commit intom5stack:masterfrom
chipguyhere wants to merge 1 commit intom5stack:masterfrom
Conversation
TinyuZhao
force-pushed
the
master
branch
2 times, most recently
from
123e101 to
2feddca
Compare
Member
|
I would like to ask if you use platformIO to determine the flash occupied when building the project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when I use the POWER class to shut down the M5Stack Core device, my flash requirements grew by over 600KB.
I discovered that this was because there's a call to shutdown the BT stack as part of the process that brings current consumption to a minimum. But I'm not using the BT stack, so shutting it down is not necessary, and having it present in my binary is counterproductive.
This change makes the call to shutdown the BT stack into a weak reference, so it only gets called if the BT stack is already linked, but without linking it if it's not otherwise being used.