fix: make elf32 and elf64 features additive (fixes #348)#535
Open
leno23 wants to merge 1 commit into
Open
Conversation
Enable each ELF feature to pull in the other so builds with only elf32 or elf64 no longer fail (fixes m4b#348). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elf32andelf64Cargo features mutually enable each other so selecting only one no longer breaks the build.Fixes #348.
The ELF parser currently references both 32-bit and 64-bit modules in shared code paths. Requiring both features when either is enabled matches Cargo's additive feature guidance and avoids compile failures for users trimming dependencies.
Suggested approach from @d-e-s-o in the issue.
Test plan
cargo check --no-default-features --features "std,elf32"cargo check --no-default-features --features "std,elf64"cargo test --lib